diff --git a/usr.sbin/rpc.tlsclntd/rpc.tlsclntd.c b/usr.sbin/rpc.tlsclntd/rpc.tlsclntd.c --- a/usr.sbin/rpc.tlsclntd/rpc.tlsclntd.c +++ b/usr.sbin/rpc.tlsclntd/rpc.tlsclntd.c @@ -87,9 +87,6 @@ static struct pidfh *rpctls_pfh = NULL; static const char *rpctls_certdir = _PATH_CERTANDKEY; static const char *rpctls_ciphers = NULL; -static uint64_t rpctls_ssl_refno = 0; -static uint64_t rpctls_ssl_sec = 0; -static uint64_t rpctls_ssl_usec = 0; static int rpctls_tlsvers = TLS1_3_VERSION; static void rpctlscd_terminate(int); @@ -98,7 +95,7 @@ u_int certlen, X509 **certp); static void rpctls_huphandler(int sig __unused); -extern void rpctlscd_1(struct svc_req *rqstp, SVCXPRT *transp); +extern void rpctlscd_2(struct svc_req *rqstp, SVCXPRT *transp); static struct option longopts[] = { { "usetls1_2", no_argument, NULL, '2' }, @@ -119,8 +116,6 @@ int ch; SVCXPRT *xprt; bool tls_enable; - struct timeval tm; - struct timezone tz; pid_t otherpid; size_t tls_enable_len; @@ -138,11 +133,6 @@ NULL, 0) != 0 || !tls_enable) errx(1, "Kernel TLS not enabled"); - /* Get the time when this daemon is started. */ - gettimeofday(&tm, &tz); - rpctls_ssl_sec = tm.tv_sec; - rpctls_ssl_usec = tm.tv_usec; - rpctls_verbose = false; while ((ch = getopt_long(argc, argv, "2C:D:dl:mp:r:v", longopts, NULL)) != -1) { @@ -233,7 +223,7 @@ } err(1, "Can't create transport for local rpctlscd socket"); } - if (!svc_reg(xprt, RPCTLSCD, RPCTLSCDVERS, rpctlscd_1, NULL)) { + if (!svc_reg(xprt, RPCTLSCD, RPCTLSCDVERS, rpctlscd_2, NULL)) { if (rpctls_debug_level == 0) { syslog(LOG_ERR, "Can't register service for local rpctlscd socket"); @@ -249,7 +239,7 @@ } bool_t -rpctlscd_null_1_svc(__unused void *argp, __unused void *result, +rpctlscd_null_2_svc(__unused void *argp, __unused void *result, __unused struct svc_req *rqstp) { @@ -258,7 +248,7 @@ } bool_t -rpctlscd_connect_1_svc(struct rpctlscd_connect_arg *argp, +rpctlscd_connect_2_svc(struct rpctlscd_connect_arg *argp, struct rpctlscd_connect_res *result, __unused struct svc_req *rqstp) { int s; @@ -281,28 +271,18 @@ rpctls_verbose_out("rpctlsd_connect: can't do TLS " "handshake\n"); result->reterr = RPCTLSERR_NOSSL; - } else { - result->reterr = RPCTLSERR_OK; - result->sec = rpctls_ssl_sec; - result->usec = rpctls_ssl_usec; - result->ssl = ++rpctls_ssl_refno; - /* Hard to believe this will ever wrap around.. */ - if (rpctls_ssl_refno == 0) - result->ssl = ++rpctls_ssl_refno; - } - - if (ssl == NULL) { /* * For RPC-over-TLS, this upcall is expected * to close off the socket. */ close(s); return (TRUE); - } + } else + result->reterr = RPCTLSERR_OK; /* Maintain list of all current SSL *'s */ newslp = malloc(sizeof(*newslp)); - newslp->refno = rpctls_ssl_refno; + newslp->refno = argp->socookie; newslp->s = s; newslp->shutoff = false; newslp->ssl = ssl; @@ -312,21 +292,16 @@ } bool_t -rpctlscd_handlerecord_1_svc(struct rpctlscd_handlerecord_arg *argp, +rpctlscd_handlerecord_2_svc(struct rpctlscd_handlerecord_arg *argp, struct rpctlscd_handlerecord_res *result, __unused struct svc_req *rqstp) { struct ssl_entry *slp; int ret; char junk; - slp = NULL; - if (argp->sec == rpctls_ssl_sec && argp->usec == - rpctls_ssl_usec) { - LIST_FOREACH(slp, &rpctls_ssllist, next) { - if (slp->refno == argp->ssl) - break; - } - } + LIST_FOREACH(slp, &rpctls_ssllist, next) + if (slp->refno == argp->socookie) + break; if (slp != NULL) { rpctls_verbose_out("rpctlscd_handlerecord fd=%d\n", @@ -355,20 +330,15 @@ } bool_t -rpctlscd_disconnect_1_svc(struct rpctlscd_disconnect_arg *argp, +rpctlscd_disconnect_2_svc(struct rpctlscd_disconnect_arg *argp, struct rpctlscd_disconnect_res *result, __unused struct svc_req *rqstp) { struct ssl_entry *slp; int ret; - slp = NULL; - if (argp->sec == rpctls_ssl_sec && argp->usec == - rpctls_ssl_usec) { - LIST_FOREACH(slp, &rpctls_ssllist, next) { - if (slp->refno == argp->ssl) - break; - } - } + LIST_FOREACH(slp, &rpctls_ssllist, next) + if (slp->refno == argp->socookie) + break; if (slp != NULL) { rpctls_verbose_out("rpctlscd_disconnect: fd=%d closed\n", @@ -401,7 +371,7 @@ } int -rpctlscd_1_freeresult(__unused SVCXPRT *transp, __unused xdrproc_t xdr_result, +rpctlscd_2_freeresult(__unused SVCXPRT *transp, __unused xdrproc_t xdr_result, __unused caddr_t result) {