Page MenuHomeFreeBSD

geom_flashmap: Rename the kernel module
ClosedPublic

Authored by markj on Oct 28 2024, 3:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 9:52 AM
Unknown Object (File)
Nov 2 2024, 6:44 AM
Unknown Object (File)
Oct 29 2024, 10:48 PM
Subscribers
None

Details

Summary

Absent a linker.hints, if a module dependency exists on disk, the loader
will automatically load it. That is, if something depends on module
foo, and foo.ko exists, we'll load foo.ko even though the linker hints
file is missing. It's a bit of a hack but it's handy.

This breaks with geom_flashmap though, since it's geom_flashmap.ko on
disk but the module is called g_flashmap. However, pretty much every
other GEOM module is given a "geom_" prefix, so for consistency's sake
alone, it seems nice to rename the module.

PR: 274388

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Oct 28 2024, 3:30 PM
markj created this revision.
This revision is now accepted and ready to land.Oct 29 2024, 3:09 PM

For FDT, this likely never will be loadable (since it would come from a partition it would map).
For mmc, it might, but partitions there are little used (in this sense of a partition, not GPT).
But either way, this is good.

This revision was automatically updated to reflect the committed changes.