Page MenuHomeFreeBSD

textproc/kibana41: copy to kibana42 and patch, create slave kibana43
ClosedPublic

Authored by skozlov on Nov 26 2015, 7:43 PM.
Tags
None
Referenced Files
F103228305: D4289.id10525.diff
Fri, Nov 22, 10:42 AM
F103161046: D4289.diff
Thu, Nov 21, 6:13 PM
F103149874: D4289.diff
Thu, Nov 21, 3:39 PM
Unknown Object (File)
Fri, Nov 15, 8:37 PM
Unknown Object (File)
Sun, Nov 10, 2:38 AM
Unknown Object (File)
Sun, Nov 10, 1:10 AM
Unknown Object (File)
Sat, Nov 9, 9:06 PM
Unknown Object (File)
Sat, Nov 9, 8:51 PM
Subscribers
None

Details

Summary

Both Kibana 4.2 and 4.3 are out compatible with Elasticsearch 2.0 and 2.1 accordingly.
Decided to copy kibana41 port to kibana42 and patch to make changes more visible

Changes:

  • Added kibana42 and kibana43 to the list of ports
  • In kibana42 make some variables conditional to make kinana43 a slave port
  • Added https MASTER_SITES as a first option
  • New versions rely on node 0.12, change RUN_DEPENDS accordingly
  • Copy the config file before deleting directories, as it will also delete the config file
  • New kibana has to be launched in the different way, reflect that in rc script
  • New kibana can write to log file by itself, delete all output redirection magic from rc script

Release notes:
https://www.elastic.co/guide/en/kibana/4.2/releasenotes.html
https://www.elastic.co/guide/en/kibana/4.3/releasenotes.html

Test Plan
  • Kibana42 poudriere testport run:
  • Kibana43 poudriere testport run:
  • Portlint outputs are included in poudriere runs. Portlint is going crazy about kibana43, because it's a slave port and lacks a lot of entries
  • Both versions were smoke tested against compatible elasticsearch versions. Data was generated by logstash parsing local logs

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

skozlov retitled this revision from to textproc/kibana41: copy to kibana42 and patch, create slave kibana43.
skozlov updated this object.
skozlov edited the test plan for this revision. (Show Details)
skozlov added a reviewer: junovitch.
skozlov set the repository for this revision to rP FreeBSD ports repository.

Corrected a copy-paste error in kibana43/pkg-descr

I'm not sure if there was a minor difference between the tested version and the one in the review but I saw this and fixed it.

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%WWWDIR%%/src/ui/public/typeahead/_input.js
Error: Orphaned: %%WWWDIR%%/src/ui/public/typeahead/_items.js
Error: Orphaned: %%WWWDIR%%/src/ui/public/typeahead/partials/typeahead-items.html
Error: Orphaned: %%WWWDIR%%/src/ui/public/typeahead/typeahead.js
Error: Orphaned: %%WWWDIR%%/src/ui/public/typeahead/typeahead.less
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%WWWDIR%%/src/ui/public/typea_input.js
Error: Missing: %%WWWDIR%%/src/ui/public/typea_items.js
Error: Missing: %%WWWDIR%%/src/ui/public/typeapartials/typeahead-items.html
Error: Missing: %%WWWDIR%%/src/ui/public/typeatypeahead.js
Error: Missing: %%WWWDIR%%/src/ui/public/typeatypeahead.less
junovitch edited edge metadata.

Committed with minor changes;
https://svnweb.FreeBSD.org/changeset/ports/402633 (textproc/kibana42)
https://svnweb.FreeBSD.org/changeset/ports/402634 (textproc/kibana43)

Note the order of operations for the cleanest SVN history was svn cp kibana41 kibana42, test/validate/commit, svn cp kibana42 kibana43, test/validate/commit.

Also, most folks will likely have just ports/head checked out so you can generate your Phabricator diffs right from head rather than one left below. That will make it easiest to apply via the arc patch DXXXX command.

This revision is now accepted and ready to land.Nov 30 2015, 12:00 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.