net-mgmt/seafile Update to 5.0.2

[matthew]

Summary

This patch is an update to the most recent version of Seafile. There are many changes to the patch files mostly for portlint satisfaction. The update also brings an undesirable bug (ASCII \ bug with sed).

* Updated to 5.0.2
* Added LICENSE_FILE
* Added max python version
* Added many SHEBANGFIX files
* A Few patch files needed to be adjusting for update
* Sed fixed for BSD bug.
* Added %%FUSE%% to plist to make poudriere =D

Test Plan

Currently testing, and using this patch. It works better then current
version. Have created many jails and installed this port to verify working order.
Poudriere is happy on with bulk -t on 102amd64, 102i386, 93amd64, and 93i386.

[koobs]

In addition to my inline comments, please add

• Description/Rationale for the patches
• Add references URL's to the headers of patch files showing where they came from
• Note in your description (that will become the commit log) whether these patches are being sent upstream, including Issue, Pull Request, Commit, or Mailing List URLs

net-mgmt/seafile/Makefile

4

Other reviews are for updates to 4.4.2. Should this be the same?

7

Why aren't the other ports also in devel category?

These should be consistently with or without it.

12–13

Add LICENSE_FILE if one exists in WRKSRC

[ultima1252_gmail.com]

• Added LICENSE_FILE
• Changed USES python:-2.7
• Added SHEBANG_FILES for several python/bash scripts.

[ultima1252_gmail.com]

net-mgmt/seafile/Makefile

4

Minor versions are small bug fixes, Seafile-gui is the client and 4.4.2 is the latest version currently.

[ultima1252_gmail.com]

• Changed script to call python2.7 instead of python

[miwi]

take

[koobs]

UIDs

254 ↗

(On Diff #11782)

Make pretty: "Seafile User"

net-mgmt/seafile/Makefile

7

• Missing python as tertiary category
• I don't agree with devel as a category

10

Upstream short description is:

Open Source Cloud Storage

• Add (Server) to the end of this comment, add (Name) to other ports to distinguish between each port/package

15

Does this actually depend on and "call" the binary, or includes & headers, library or other things? Is fo, LIB_DEPENDS may be more appropriate

110

What is this for? Why is it necessary?

net-mgmt/seafile/files/patch-configure.ac

62

Unnecessary whitespace changes?

net-mgmt/seafile/files/patch-daemon_Makefile.am

17

Is this going upstream?

net-mgmt/seafile/files/patch-daemon_http-tx-mgr.c

2

Is there an upstream Issue/PR for this? If so add breadcrumbs/links

net-mgmt/seafile/files/patch-lib_Makefile.am

26

This doesn't look right. DESTDIR should be STAGEDIR (which the framework passes to make), PREFIX is completely differerent

net-mgmt/seafile/files/patch-scripts_upgrade_regenerate__secret__key.sh

9

This needs to be ${PYTHON_CMD} and ideally not hidden in a patchfile, REINPLACE_CMD it in the Makefile

net-mgmt/seafile/pkg-plist

55

I'm not a fan of this (%%SEAFILE_SERVER%%) variable name, or use in the pkg-plist

[miwi]

net-mgmt/seafile/files/patch-configure.ac

62

no it needed to regenerated.

[ultima1252_gmail.com]

net-mgmt/seafile/Makefile

110

do-install will install this, the line above it copies to the seafile directory. This line removes the duplicate.

[matthew]

Port is currently at version 6.0.0. Close this as Overcome By Events?

[matthew]

Overcome by events