12.4: RELEASE (not upcoming), and missing links

[grahamperrin]

Summary

FreeBSD bug 268287, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268287.

shared/releases.adoc

• see the commit message at https://github.com/grahamperrin/freebsd-doc/commit/01eebbf0fa5a28a9fdd3aef18566b8e9efba6eb9.

website/content/en/releases/12.4R/_index.adoc

• for https://www.freebsd.org/releases/12.4R/
• hidden lines are now visible.

website/themes/beastie/layouts/partials/sidenav.html

• part of which is for the sidebar at pages such as https://www.freebsd.org/releases/12.4R/.

Origin of the first diff here:

• https://github.com/freebsd/freebsd-doc/compare/main...grahamperrin:freebsd-doc:bug-268287.diff.

Test Plan

Preview in GitHub:

• https://github.com/grahamperrin/freebsd-doc/blob/bug-268287/website/content/en/releases/12.4R/_index.adoc.

Consider other pages that use what's currently named shared/releases.adoc … was any such page updated, with reference to 12.4-RELEASE, after 12.4-RELEASE was announced?

[carlavilla]

shared/releases.adoc is an AsciiDoc file, don't change the name

[grahamperrin]

From the test plan:

Consider other pages that use what's currently named shared/releases.adoc … was any such page updated, with reference to 12.4-RELEASE, after 12.4-RELEASE was announced?

More specifically: consider the changes to beta lines in https://reviews.freebsd.org/D37978#change-ZGKMDKf8nj4R.

I sped through five of the eight files listed below, the /en/ files. As far as I can tell: none will be adversely affected.

% git -C /usr/doc switch main
Switched to branch 'main'
Your branch is up to date with 'origin/main'.
% git -C /usr/doc pull --ff-only
Already up to date.
% find /usr/doc/website -newerct '5 weeks ago' -type f -exec grep 'include::shared/releases' {} +
/usr/doc/website/content/ja/releases/_index.adoc:include::shared/releases.adoc[]
/usr/doc/website/content/ja/security/_index.adoc:include::shared/releases.adoc[]
/usr/doc/website/content/ja/where.adoc:include::shared/releases.adoc[]
/usr/doc/website/content/en/where.adoc:include::shared/releases.adoc[]
/usr/doc/website/content/en/releases/12.4R/readme.adoc:include::shared/releases.adoc[]
/usr/doc/website/content/en/releases/12.4R/announce.adoc:include::shared/releases.adoc[]
/usr/doc/website/content/en/releases/_index.adoc:include::shared/releases.adoc[]
/usr/doc/website/content/en/security/_index.adoc:include::shared/releases.adoc[]
%

[grahamperrin]

In D37978#862814, @carlavilla wrote:

shared/releases.adoc is an AsciiDoc file, …

@carlavilla thanks for confirming.

I made a false assumption when I could not preview a diff before the commit to my branch.

Post-commit, it's remarkable that https://github.com/grahamperrin/freebsd-doc/blob/01eebbf0fa5a28a9fdd3aef18566b8e9efba6eb9/shared/releases.adoc#L33 and https://github.com/grahamperrin/freebsd-doc/blob/01eebbf0fa5a28a9fdd3aef18566b8e9efba6eb9/shared/releases.adoc#L44 (lines 33 and 44) are not greyed-out.

For both of those, re: https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#comments, my intention was a single-line comment without having an empty line before or after the comment. Can anyone tell, is my use of single-line commentary not valid?

---

The prior emptiness, the ambiguity, might partly explain the disorder that is (hopefully) corrected at https://github.com/grahamperrin/freebsd-doc/commit/01eebbf0fa5a28a9fdd3aef18566b8e9efba6eb9?diff=unified#diff-1f11b6e6572daca22d97764f7ba84761d3b44e046096730c87a9b16047de7f2dR66-R68.

[grahamperrin]

Now overlapping with recent commits.

https://reviews.freebsd.org/source/doc/history/main/website/themes/beastie/layouts/partials/sidenav.html

[lwhsu]

This differential contains too much changes, I suggest commit website/content/en/releases/12.4R/_index.adoc first, Then open another fine with rebased other changes.