Page MenuHomeFreeBSD

Mark imported state as PFTM_UNLINKED before freeing it
AbandonedPublic

Authored by mjg on Dec 5 2022, 4:16 PM.
Tags
None
Referenced Files
F99465715: D37601.diff
Wed, Oct 9, 9:49 PM
Unknown Object (File)
Wed, Oct 2, 4:39 PM
Unknown Object (File)
Wed, Sep 18, 1:23 AM
Unknown Object (File)
Sep 4 2024, 8:49 PM
Unknown Object (File)
Sep 2 2024, 5:43 AM
Unknown Object (File)
Aug 23 2024, 10:19 AM
Unknown Object (File)
May 3 2024, 9:23 AM
Unknown Object (File)
Mar 31 2024, 7:09 AM

Details

Summary

When using a kernel with KASSERT checks enabled, a state import failure (for example due to "wire key attach failed") causes a kernel panic due to the failed state not being set to PFTM_UNLINKED timeout. This patch sets the timeout correctly for such states.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

That's a good fix, but it looks like you're working from an older version. This is already fixed in https://cgit.freebsd.org/src/commit/?id=69ce6ae21acd71b8e46d1f22176063e9d243511a

It seems it didn't get MFC'd though, so that may be why you ran into this. I'll see about fixing that at least.

This comment was removed by glebius.
mjg commandeered this revision.EditedDec 7 2022, 4:01 AM
mjg added a reviewer: vegeta_tuxpowered.net.
mjg added a subscriber: mjg.

As noted by kp@ this is already fixed in the main branch. He recently MFCed it to stable/13 (7efa85c12303c532b3c87d08dc6e6020fb2c18cc) and to stable/12 (577214cb0ac6c1433b39503af5b7b50e8f9985d5).

As there is nothing more to do regarding this bug I'm going to close this revision.

Thanks for the patch nonetheless and apologies for not merging sooner :)