beastie theme: en.toml apostrophes and more

[grahamperrin]

Summary

Apostrophes are not necessary in phrases such as 'FreeBSD's Handbook' and 'Documentation's Handbook'.

'Presentation and papers': should be plural, 'Presentations and papers'.

A few other suggested changes.

---

I noticed FreeBSD's Handbook at https://docs.freebsd.org/en/ a few weeks ago.

The diff here in Phabricator is taken from the beastie-theme-en branch of my fork in GitHub, https://github.com/grahamperrin/freebsd-doc/tree/beastie-theme-en.

Test Plan

Re: https://github.com/freebsd/freebsd-doc/search?q=download-freebsd, download-freebsd is found in https://github.com/freebsd/freebsd-doc/blob/main/documentation/themes/beastie/layouts/index.html.

[grahamperrin]

documentation/themes/beastie/i18n/en.toml

155

Is this the origin of the words in the yellow button at the home page?

[pauamma_gundo.com]

Test plan looks like it has text intended for summary?

English change itself LGTM.

[grahamperrin]

Thanks,

In D37503#852614, @pauamma wrote:

Test plan looks like it has text intended for summary?

Yeah, I couldn't put what I really wanted in the test plan at the time of creating the review.

Re: subsequent https://reviews.freebsd.org/D37503#852612, I'm unsure of the effect of changing download-freebsd.

[grahamperrin]

documentation/themes/beastie/i18n/en.toml

155

On closer inspection, more likely the origin of this part of https://docs.freebsd.org/en/:

(Not the origin of what's in the yellow button in the previous comment.)

Can someone confirm? Thanks

[carlavilla]

Looks good to me.
Only to improve my English. Why "FreeBSD's Handbook" is not ok?
I always thought that you use this to express that the Handbook is "property?" of FreeBSD.

[ceri]

In D37503#852734, @carlavilla wrote:

Looks good to me.
Only to improve my English. Why "FreeBSD's Handbook" is not ok?
I always thought that you use this to express that the Handbook is "property?" of FreeBSD.

That’s correct, and strictly speaking it is correct if you think of the Handbook as belonging to FreeBSD. However, it is preferable to express as the “FreeBSD Handbook” to show that it is a handbook *about* FreeBSD.

If you think about “Cat Handbook” vs “Cat’s Handbook” the difference may be clearer.

[pauamma_gundo.com]

documentation/themes/beastie/i18n/en.toml

155

Definitely the yellow "Download FreeBSD" button. Maybe the other text as well. I can't tell for sure. Check

[pauamma@Pusat-Tasek] ~/FreeBSD/doc% git grep -F -A 1 download-freebsd
...
documentation/themes/beastie/i18n/en.toml:[download-freebsd]
documentation/themes/beastie/i18n/en.toml-other = "Download FreeBSD"
--
documentation/themes/beastie/i18n/es.toml:[download-freebsd]
documentation/themes/beastie/i18n/es.toml-other = "Descargar FreeBSD"
--
documentation/themes/beastie/i18n/fr.toml:[download-freebsd]
documentation/themes/beastie/i18n/fr.toml-other = "Télécharger FreeBSD"
...
--
documentation/themes/beastie/i18n/ja.toml:[download-freebsd]
documentation/themes/beastie/i18n/ja.toml-other = "FreeBSD を入手する"

against https://www.freebsd.org/, https://www.freebsd.org/es/, https://www.freebsd.org/fr/, and https://www.freebsd.org/ja/.

[carlavilla]

documentation/themes/beastie/i18n/en.toml

155

Sorry, I forgot this.
No, this in in the website folder.

[grahamperrin]

Re: D37503#852734

An additional example: the apostrophe in owner's manual – https://en.wikipedia.org/wiki/Owner's_manual.

A manual held by the owner of a Mercedes-Benz:

The example in Wikipedia https://en.wikipedia.org/wiki/Owner's_manual#/media/File:Yaris_Owner_Manual.jpg might be described, loosely, as a Toyota owner's manual or Toyota manual but not as a Toyota's manual.

[grahamperrin]

Changes are visible at https://docs.freebsd.org/en/. (Compare with e.g. https://web.archive.org/web/20221021070131/https://docs.freebsd.org/en/.)

---

09ae2c2d17605a4fcb3aa1ee381abbce01a95a43

• https://reviews.freebsd.org/R9:09ae2c2d17605a4fcb3aa1ee381abbce01a95a43
• https://cgit.freebsd.org/doc/commit/?id=09ae2c2d17605a4fcb3aa1ee381abbce01a95a43
• https://codeberg.org/FreeBSD/freebsd-doc/commit/09ae2c2d17605a4fcb3aa1ee381abbce01a95a43
• https://gitlab.com/FreeBSD/freebsd-doc/-/commit/09ae2c2d17605a4fcb3aa1ee381abbce01a95a43
• https://github.com/freebsd/freebsd-doc/commit/09ae2c2d17605a4fcb3aa1ee381abbce01a95a43

documentation/themes/beastie/i18n/en.toml

155

Outcome: wording in the yellow button was not affected by today's commit.

[grahamperrin]

grahamperrin marked 2 inline comments as done.

(Not true. I marked 4 inline comments as done.)