Page MenuHomeFreeBSD

git-arc: Accept message via -m when updating reviews.
ClosedPublic

Authored by jhb on Nov 4 2022, 12:00 AM.
Tags
None
Referenced Files
F105305638: D37260.diff
Sat, Dec 14, 5:34 PM
Unknown Object (File)
Mon, Nov 18, 9:39 AM
Unknown Object (File)
Fri, Nov 15, 2:08 PM
Unknown Object (File)
Oct 18 2024, 1:26 PM
Unknown Object (File)
Oct 11 2024, 8:29 AM
Unknown Object (File)
Oct 1 2024, 6:32 AM
Unknown Object (File)
Sep 30 2024, 1:42 PM
Unknown Object (File)
Sep 30 2024, 1:33 PM
Subscribers

Details

Summary

If a -m argument is given to update, it is passed through to arc diff
when updating each review. Note that if an empty message is specified
via -m, arc diff will update the review without adding a note.

If an -m argument is not given, then the user's editor is invoked by
arc to supply a message for each review matching the previous
behavior.

This can be used to simplify the process for updating a set of
reviews, e.g.:

git checkout foo
git rebase main
git arc update -m "Rebase" main..

This will rebase the 'foo' branch and update the reviews for all
commits on the branch without invoking the user's editor separately
for each review.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48138
Build 45025: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Nov 4 2022, 12:00 AM
markj added inline comments.
tools/tools/git/git-arc.sh
536

There's extra indentation here.

This revision is now accepted and ready to land.Nov 4 2022, 2:42 PM
This revision was automatically updated to reflect the committed changes.
jhb marked an inline comment as done.