stand: Create MOD_ALIGN macro and use it everywhere
ClosedPublic
Actions

Authored by imp on Sep 14 2022, 7:38 PM.

Details

Reviewers

manu
tsoome
kevans

Group Reviewers

bhyve

Commits

rG9bc956361bcc: stand: Create MOD_ALIGN macro and use it everywhere
rG8b19d28d68a3: stand: Create MOD_ALIGN macro and use it everywhere

Summary

To further reduce the differences between the different MOD_xxx macros,
use MOD_ALIGN to do the proper alignment for the given use.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47386
Build 44273: arc lint + arc unit

Event Timeline

imp created this revision.Sep 14 2022, 7:38 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 14 2022, 7:38 PM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript

imp requested review of this revision.Sep 14 2022, 7:38 PM

Harbormaster completed remote builds in B47386: Diff 110562.Sep 14 2022, 7:38 PM

imp added a child revision: D36571: stand: Create common/modinfo.h.Sep 14 2022, 7:43 PM

imp added reviewers: tsoome, kevans.

imp added a parent revision: D36569: stand: use archsw.arch_copyin instead of direct call.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2022, 3:54 PM

Closed by commit rG8b19d28d68a3: stand: Create MOD_ALIGN macro and use it everywhere (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG8b19d28d68a3: stand: Create MOD_ALIGN macro and use it everywhere.

imp added a commit: rG9bc956361bcc: stand: Create MOD_ALIGN macro and use it everywhere.Jan 24 2023, 10:17 PM

Revision Contents
Changeset List

Path

Size

stand/

common/

metadata.c

7 lines

efi/

loader/

bootinfo.c

9 lines

i386/

libi386/

bootinfo32.c

7 lines

bootinfo64.c

7 lines

userboot/

bootinfo32.c

7 lines

bootinfo64.c

7 lines

Diff 110562

View Options

stand/common/metadata.c

View Options

stand/efi/loader/bootinfo.c

View Options

stand/i386/libi386/bootinfo32.c

View Options

stand/i386/libi386/bootinfo64.c

View Options

stand/userboot/userboot/bootinfo32.c

View Options

stand/userboot/userboot/bootinfo64.c

stand: Create MOD_ALIGN macro and use it everywhereClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 110562

stand/common/metadata.c

stand/efi/loader/bootinfo.c

stand/i386/libi386/bootinfo32.c

stand/i386/libi386/bootinfo64.c

stand/userboot/userboot/bootinfo32.c

stand/userboot/userboot/bootinfo64.c

stand: Create MOD_ALIGN macro and use it everywhere
ClosedPublic
Actions

Revision Contents
Changeset List