Page MenuHomeFreeBSD

Turn readline into an internallib
ClosedPublic

Authored by bapt on Jul 5 2014, 6:16 PM.
Tags
None
Referenced Files
F81985112: D365.diff
Wed, Apr 24, 3:46 AM
Unknown Object (File)
Sat, Apr 20, 8:01 PM
Unknown Object (File)
Sat, Apr 20, 7:53 PM
Unknown Object (File)
Sat, Apr 20, 7:40 PM
Unknown Object (File)
Sat, Apr 20, 3:58 AM
Unknown Object (File)
Fri, Apr 19, 10:57 AM
Unknown Object (File)
Thu, Mar 28, 12:32 PM
Unknown Object (File)
Tue, Mar 26, 8:07 AM
Subscribers
None

Details

Summary

Turn readline into an internallib for gdb

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bapt retitled this revision from to Turn readline into an internallib.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: emaste.

Add manpage as obsolete files

Add libhistory to obsolete files

This looks good to me, but I'm not entirely sure this is the right way to do this, but I can't offer a constructive comment on how to make it better.

If gdb is the only in-tree consumer of libreadline, can we just statically link it into gdb and remove the .so entirely?

@theraven that is what this patch does ;)
@imp yup I could not find a better way either

Or, right, sorry. I misunderstood and thought it was being moved into private. Reading it a bit more carefully, it looks fine.

Can you add the UPADTING entry in here too? This passed an exp run already, correct?

Be sure to highlight reasons for removing it in the commit message - e.g., having ports use readline from ports allows it to be kept up-to-date. Specifically, it's not just because of the GPL that it's being removed.

ObsoleteFiles.inc
42

OLD_LIBS=

49

OLD_LIBS=

Here's my take:

20140707:
        The GNU readline library is now an INTERNALLIB - that is, it is
        statically linked into consumers (GDB and variants) in the base
        system, and the shared library is no longer installed.  The
        devel/readline port is available for third party software that
        requires readline.
bapt edited edge metadata.

Add UPDATING and Fix the obsolete file

emaste edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 3:40 PM