One non-obvious barrier to getting NIC kTLS to work on lagged interfaces is ensuring that lagg is running in use_flowid mode. If it is not, it will not allocate send tags, and software kTLS will be used.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
sys/net/if_lagg.c | ||
---|---|---|
1898 | I wonder if the NET_EPOCH_EXIT(et) should be last! You are reading some fields, and they may be freed!? |
sys/net/if_lagg.c | ||
---|---|---|
1898 | I thought it was there to protect against the lagg port interfaces going away, but its easy enough to move it after the warning out of an abundance of caution. |
sys/net/if_lagg.c | ||
---|---|---|
1891 | Maybe make warned another sc flag that gets removed/set on LAGG_OPT_USE_FLOWID flag change? if (__predict_false(sc->sc_opts & LAGG_NEED_WARN)) { NET_EPOCH_EXIT(); warn_lagg_user(sc); return (EOPNOSUPP); } ? |