Differential D36326

uart: Read clock frequency from bus
ClosedPublic
Actions

Authored by mkoz_semihalf.com on Aug 24 2022, 9:01 AM.

Tags

None

Referenced Files

	F81982143: D36326.diff
	Wed, Apr 24, 2:45 AM

	Unknown Object (File)
	Mon, Apr 22, 9:56 PM

	Unknown Object (File)
	Mon, Apr 22, 3:22 AM

	Unknown Object (File)
	Sun, Apr 7, 8:23 AM

	Unknown Object (File)
	Sat, Apr 6, 5:12 PM

	Unknown Object (File)
	Tue, Apr 2, 9:59 PM

	Unknown Object (File)
	Mar 2 2024, 7:26 AM

	Unknown Object (File)
	Mar 2 2024, 7:26 AM

View All 43 Files

Subscribers

Details

Reviewers

mw
kd
wma
bz

Commits

rG299b6c9cb1a9: uart_bus_acpi: Read clock frequency from bus

Summary

It is stored in clock-frequency.
In case of failure, fallback to the harcoded value stored in the compat data.
While here improve style.
Tested on LS1046ARDB and x86 PC.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mkoz_semihalf.com requested review of this revision.Aug 24 2022, 9:01 AM

mkoz_semihalf.com created this revision.

mkoz_semihalf.com retitled this revision from uart: Read clock frequency provided from bus to uart: Read clock frequency from bus.Aug 24 2022, 9:05 AM

mw requested changes to this revision.Sep 5 2022, 11:06 PM

mw added inline comments.

sys/dev/uart/uart_bus_acpi.c
88	Don't assign value in declaration block.
95	missing space after return.

This revision now requires changes to proceed.Sep 5 2022, 11:06 PM

mkoz_semihalf.com updated this revision to Diff 110181.Sep 6 2022, 8:38 AM

This comment was removed by mkoz_semihalf.com.

mkoz_semihalf.com updated this revision to Diff 110188.Sep 6 2022, 8:49 AM

This comment was removed by mkoz_semihalf.com.

Move assignment.
Fix style in return statement.

Remove empty line.

mw accepted this revision.Sep 6 2022, 11:40 AM

This revision is now accepted and ready to land.Sep 6 2022, 11:40 AM

Closed by commit rG299b6c9cb1a9: uart_bus_acpi: Read clock frequency from bus (authored by mkoz_semihalf.com, committed by kd). · Explain WhySep 7 2022, 8:00 AM

This revision was automatically updated to reflect the committed changes.

kd added a commit: rG299b6c9cb1a9: uart_bus_acpi: Read clock frequency from bus.

Herald added a subscriber: imp. · View Herald TranscriptSep 7 2022, 8:00 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

uart/

uart_bus_acpi.c

5 lines

Diff 110181

sys/dev/uart/uart_bus_acpi.c

Loading...