Page MenuHomeFreeBSD

udp: call UDP methods from UDP over IPv6 directly
ClosedPublic

Authored by glebius on Aug 12 2022, 8:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2024, 2:47 PM
Unknown Object (File)
Feb 20 2024, 2:47 PM
Unknown Object (File)
Feb 20 2024, 2:43 PM
Unknown Object (File)
Feb 20 2024, 10:09 AM
Unknown Object (File)
Dec 20 2023, 4:33 AM
Unknown Object (File)
Dec 12 2023, 7:43 AM
Unknown Object (File)
Dec 3 2023, 8:39 AM
Unknown Object (File)
Dec 3 2023, 8:39 AM
Subscribers

Details

Summary

Both UDP and UDP Lite use same methods on sockets. Both UDP over IPv4
and over IPv6 use same methods. Don't pretend that methods can switch
and remove this unneeded complexity.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro added inline comments.
sys/netinet6/udp6_usrreq.c
137–140

We already include netinet/udp_var.h, which contains udp_input() and other similar functions definitions. Maybe worth putting these definitions there?

sys/netinet6/udp6_usrreq.c
137–140

I think that when a function is shared only between two files, it is better not make it officially public.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2022, 7:41 PM
This revision was automatically updated to reflect the committed changes.