Paths

Table of Contentst

Differential D36140

ipfw: make it possible to specify MTU for "unreach needfrag" action
ClosedPublic
Actions

Authored by glebius on Aug 11 2022, 2:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 22, 9:41 PM

	Unknown Object (File)
	Mon, Apr 22, 9:28 PM

	Unknown Object (File)
	Mon, Apr 22, 3:15 PM

	Unknown Object (File)
	Mon, Apr 22, 8:36 AM

	Unknown Object (File)
	Mon, Apr 22, 8:31 AM

	Unknown Object (File)
	Wed, Apr 17, 11:23 AM

	Unknown Object (File)
	Wed, Apr 17, 2:36 AM

	Unknown Object (File)
	Sun, Apr 7, 1:23 AM

View All 52 Files

Subscribers

pauamma_gundo.com

Details

Reviewers

melifaro
ae
pauamma_gundo.com

Group Reviewers

network
manpages

Commits

rG05b9737f1064: ipfw: make it possible to specify MTU for "unreach needfrag" action

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Aug 11 2022, 2:29 PM

Herald added a reviewer: manpages. · View Herald TranscriptAug 11 2022, 2:29 PM

Herald added subscribers: donner, imp. · View Herald Transcript

glebius requested review of this revision.Aug 11 2022, 2:29 PM

Harbormaster completed remote builds in B46859: Diff 109157.Aug 11 2022, 2:29 PM

Manual page change LGTM. Can't say beyond that.

sbin/ipfw/ipfw.8
1101

This revision is now accepted and ready to land.Aug 12 2022, 7:19 PM

Do you plan add similar support for IPv6? There is ICMP6_PACKET_TOO_BIG with the same meaning. But actually it is not unreach message, thus I'm not sure we should do it.

In D36140#821882, @ae wrote:

Do you plan add similar support for IPv6? There is ICMP6_PACKET_TOO_BIG with the same meaning. But actually it is not unreach message, thus I'm not sure we should do it.

No, I don't plan. Indeed it requires some rethinking of unreach6 action, so that it is able to send not only ICMP6_DST_UNREACH, but other ICMP messages. So for IPv6 the change is possible, but more complicated. I'd better leave it for somebody else :)

ae accepted this revision as: ae.Aug 17 2022, 3:16 PM

Closed by commit rG05b9737f1064: ipfw: make it possible to specify MTU for "unreach needfrag" action (authored by glebius). · Explain WhyAug 17 2022, 3:25 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG05b9737f1064: ipfw: make it possible to specify MTU for "unreach needfrag" action.

Revision Contents
Changeset List

Path

Size

sbin/

ipfw/

10 lines

15 lines

sys/

netpfil/

ipfw/

15 lines

ip_fw_sockopt.c

7 lines

Diff 109464

sbin/ipfw/ipfw.8

Loading...

sbin/ipfw/ipfw2.c

Loading...

sys/netpfil/ipfw/ip_fw2.c

Loading...

sys/netpfil/ipfw/ip_fw_sockopt.c

Loading...