sys: rename linker scripts to .lds
Needs ReviewPublic
Actions

Authored by ehem_freebsd_m5p.com on Jul 28 2022, 11:15 PM.

Details

Reviewers

manu
andrew

Summary

Likely these were originally named .lds.s since the author thought
they were being handled by the assembler. Instead these are streams of
commands for the linker to interpret. As such match Linux and rename
them to .lds.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46663
Build 43552: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Jul 28 2022, 11:15 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 28 2022, 11:15 PM

Herald added subscribers: Contributor Reviews (src), emaste, andrew, imp. · View Herald Transcript

ehem_freebsd_m5p.com requested review of this revision.Jul 28 2022, 11:15 PM

Harbormaster completed remote builds in B46663: Diff 108680.Jul 28 2022, 11:15 PM

We seem to use ldscript as either an extension or base for the filename, e.g. sys/conf/ldscript.arm64 or lib/libc/libc.ldscript.

Herald added a reviewer: andrew. · View Herald TranscriptJun 26 2023, 4:15 PM

Herald added a reviewer: andrew. · View Herald Transcript

In D35976#927426, @emaste wrote:

We seem to use ldscript as either an extension or base for the filename, e.g. sys/conf/ldscript.arm64 or lib/libc/libc.ldscript.

Does appear to be so. Does this really need a re-upload and new approval? Can this simply be done during commit? (seems a trivial adjustment, mostly modifies the commit message)