Page MenuHomeFreeBSD
Differential D35612

ipmi: do not omit lun in BMC addresses
ClosedPublic
Actions

Authored by yuri_aetern.org on Jun 27 2022, 3:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 27 2024, 2:42 AM
Unknown Object (File)
Jan 21 2024, 5:21 AM
Unknown Object (File)
Jan 5 2024, 1:27 PM
Unknown Object (File)
Dec 31 2023, 4:56 AM
Unknown Object (File)
Dec 31 2023, 4:56 AM
Unknown Object (File)
Dec 31 2023, 4:56 AM
Unknown Object (File)
Dec 31 2023, 4:56 AM
Unknown Object (File)
Dec 31 2023, 4:44 AM
View All 43 Files
Subscribers
afedorov
philip

Details

Reviewers
avg
imp
philip
Commits
rG81fe400fb1e2: ipmi: do not omit lun in BMC addresses
rG177f8b3294ef: ipmi: do not omit lun in BMC addresses
Summary

Apparently some systems put sensors on non-0 lun, so we should not omit it. That was the only difference with the linux driver, where DIMM sensors (see testing part) worked and didn't on FreeBSD.

Test Plan

Tested by Andrey Lanin, see:

https://forums.freebsd.org/threads/freebsd-cannot-get-dimm-temperature-sensor-value.85166/.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

yuri_aetern.org requested review of this revision.Jun 27 2022, 3:31 PM
yuri_aetern.org created this revision.
afedorov added a subscriber: afedorov.Jun 28 2022, 5:15 PM
philip accepted this revision.Jul 3 2022, 5:50 AM
philip added a subscriber: philip.

Tested on a DL380 and seems to work.

This revision is now accepted and ready to land.Jul 3 2022, 5:50 AM
yuri_aetern.org added a comment.Jul 3 2022, 4:53 PM
In D35612#809596, @philip wrote:

Tested on a DL380 and seems to work.

Yes, it should be no-op on DL380, and is intended to fix some other (unknown as forums thread shows) system.

philip requested changes to this revision.Jul 4 2022, 5:34 AM

Would you mind rebasing this one for me? It doesn't apply cleanly after I pushed your D35605. Thanks!

This revision now requires changes to proceed.Jul 4 2022, 5:34 AM
yuri_aetern.org updated this revision to Diff 107720.Jul 4 2022, 6:21 AM

rebase

philip accepted this revision.Jul 4 2022, 6:35 AM
This revision is now accepted and ready to land.Jul 4 2022, 6:35 AM
Closed by commit rG177f8b3294ef: ipmi: do not omit lun in BMC addresses (authored by yuri_aetern.org, committed by philip). · Explain WhyJul 4 2022, 6:35 AM
This revision was automatically updated to reflect the committed changes.
philip added a commit: rG177f8b3294ef: ipmi: do not omit lun in BMC addresses.
philip added a commit: rG81fe400fb1e2: ipmi: do not omit lun in BMC addresses.Jul 11 2022, 3:16 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
ipmi/
8 lines

Diff 107434

View Options

sys/dev/ipmi/ipmi.c

Loading...