Page MenuHomeFreeBSD

libmd: stop exporting _block symbols
Needs ReviewPublic

Authored by kevans on Mar 9 2022, 3:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 18, 12:36 AM
Unknown Object (File)
Wed, Jul 10, 4:04 PM
Unknown Object (File)
Jun 14 2024, 2:22 PM
Unknown Object (File)
Jan 9 2024, 10:18 PM
Unknown Object (File)
Dec 20 2023, 6:28 AM
Unknown Object (File)
Sep 3 2023, 2:53 AM
Unknown Object (File)
May 19 2023, 3:05 PM
Unknown Object (File)
Mar 5 2023, 5:32 PM
Subscribers

Details

Summary

These are needed across compilation units so we can keep the _libmd_
prefixing bits (though I suspect we're not likely to collide), but we
don't need to be exporting the unprefixed versions of these; it's an
implementation detail.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44712
Build 41600: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Mar 9 2022, 3:34 AM

These should also be removed from <sha.h>. This change will make D45444 easier as I don't have to stick to the prototype imposed by the old code.

lib/libmd/sha1c.c
513

Do we also still need the _version symbols? They seem to be specific to SSLeay's implementation and are probably not needed anymore.

lib/libmd/sha1c.c
513

I am not aware of any consumers of it. If you do remove it, also remove RMD160_version

So we have no old binaries with the *_block symbols to resolve? I'm skeptical of that notion.

What about the _Transform symbols? These also do not seem to be declared in the header files.