Index: sys/kern/kern_shutdown.c =================================================================== --- sys/kern/kern_shutdown.c +++ sys/kern/kern_shutdown.c @@ -1177,63 +1177,56 @@ } /* - * Must not be present on global list. + * Free a dumper. Must not be present on global list. */ -static void -free_single_dumper(struct dumperinfo *di) +void +dumper_destroy(struct dumperinfo *di) { if (di == NULL) return; zfree(di->blockbuf, M_DUMPER); - kerneldumpcomp_destroy(di); - #ifdef EKCD zfree(di->kdcrypto, M_EKCD); #endif zfree(di, M_DUMPER); } -/* Registration of dumpers */ +/* + * Allocate and set up a new dumper from the provided template. + */ int -dumper_insert(const struct dumperinfo *di_template, const char *devname, - const struct diocskerneldump_arg *kda) +dumper_create(const struct dumperinfo *di_template, const char *devname, + const struct diocskerneldump_arg *kda, struct dumperinfo **dip) { - struct dumperinfo *newdi, *listdi; - bool inserted; - uint8_t index; - int error; + struct dumperinfo *newdi; - index = kda->kda_index; - MPASS(index != KDA_REMOVE && index != KDA_REMOVE_DEV && - index != KDA_REMOVE_ALL); - - error = priv_check(curthread, PRIV_SETDUMPER); - if (error != 0) - return (error); + if (dip == NULL) + return (EINVAL); - newdi = malloc(sizeof(*newdi) + strlen(devname) + 1, M_DUMPER, M_WAITOK - | M_ZERO); + /* Allocate a new dumper */ + newdi = malloc(sizeof(*newdi) + strlen(devname) + 1, M_DUMPER, + M_WAITOK | M_ZERO); memcpy(newdi, di_template, sizeof(*newdi)); newdi->blockbuf = NULL; newdi->kdcrypto = NULL; newdi->kdcomp = NULL; strcpy(newdi->di_devname, devname); + *dip = newdi; + if (kda->kda_encryption != KERNELDUMP_ENC_NONE) { #ifdef EKCD - newdi->kdcrypto = kerneldumpcrypto_create(di_template->blocksize, + newdi->kdcrypto = kerneldumpcrypto_create(newdi->blocksize, kda->kda_encryption, kda->kda_key, kda->kda_encryptedkeysize, kda->kda_encryptedkey); if (newdi->kdcrypto == NULL) { - error = EINVAL; - goto cleanup; + return (EINVAL); } #else - error = EOPNOTSUPP; - goto cleanup; + return (EOPNOTSUPP); #endif } if (kda->kda_compression != KERNELDUMP_COMP_NONE) { @@ -1245,20 +1238,44 @@ * cipher block size. */ if (kda->kda_encryption == KERNELDUMP_ENC_AES_256_CBC) { - error = EOPNOTSUPP; - goto cleanup; + return (EOPNOTSUPP); } #endif newdi->kdcomp = kerneldumpcomp_create(newdi, kda->kda_compression); if (newdi->kdcomp == NULL) { - error = EINVAL; - goto cleanup; + return (EINVAL); } } - newdi->blockbuf = malloc(newdi->blocksize, M_DUMPER, M_WAITOK | M_ZERO); + return (0); +} + +/* + * Create a new dumper and register it in the global list. + */ +int +dumper_insert(const struct dumperinfo *di_template, const char *devname, + const struct diocskerneldump_arg *kda) +{ + struct dumperinfo *newdi, *listdi; + bool inserted; + uint8_t index; + int error; + + index = kda->kda_index; + MPASS(index != KDA_REMOVE && index != KDA_REMOVE_DEV && + index != KDA_REMOVE_ALL); + + error = priv_check(curthread, PRIV_SETDUMPER); + if (error != 0) + return (error); + + error = dumper_create(di_template, devname, kda, &newdi); + if (error != 0) + goto cleanup; + /* Add the new configuration to the queue */ mtx_lock(&dumpconf_list_lk); inserted = false; @@ -1277,7 +1294,7 @@ return (0); cleanup: - free_single_dumper(newdi); + dumper_destroy(newdi); return (error); } @@ -1333,6 +1350,9 @@ return (true); } +/* + * Remove and free the requested dumper(s) from the global list. + */ int dumper_remove(const char *devname, const struct diocskerneldump_arg *kda) { @@ -1356,7 +1376,7 @@ if (dumper_config_match(di, devname, kda)) { found = true; TAILQ_REMOVE(&dumper_configs, di, di_next); - free_single_dumper(di); + dumper_destroy(di); } } mtx_unlock(&dumpconf_list_lk); Index: sys/sys/conf.h =================================================================== --- sys/sys/conf.h +++ sys/sys/conf.h @@ -365,6 +365,9 @@ void dump_savectx(void); int doadump(boolean_t); struct diocskerneldump_arg; +int dumper_create(const struct dumperinfo *di_template, const char *devname, + const struct diocskerneldump_arg *kda, struct dumperinfo **dip); +void dumper_destroy(struct dumperinfo *di); int dumper_insert(const struct dumperinfo *di_template, const char *devname, const struct diocskerneldump_arg *kda); int dumper_remove(const char *devname, const struct diocskerneldump_arg *kda);