dummynet: store current vnet when scheduling fqpie_callout_cleanup
AbandonedPublic
Actions

Authored by mjg on Jan 12 2022, 8:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 14 2024, 8:52 PM

	Unknown Object (File)
	Feb 10 2024, 10:07 PM

	Unknown Object (File)
	Dec 20 2023, 4:20 AM

	Unknown Object (File)
	Dec 12 2023, 1:23 AM

	Unknown Object (File)
	Oct 11 2023, 3:41 AM

	Unknown Object (File)
	Aug 18 2023, 8:31 AM

Subscribers

Details

Reviewers

kp
glebius

Group Reviewers

network

Summary

Otherwise it will crash as the callout runs without any vnet to begin with.

Test Plan

The code was tested by the person who reported the crash.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mjg created this revision.Jan 12 2022, 8:24 PM

Herald added subscribers: glebius, donner, melifaro and 2 others. · View Herald TranscriptJan 12 2022, 8:24 PM

mjg requested review of this revision.Jan 12 2022, 8:24 PM

Dhould we remove the packets in those queues on vnet destruction?

kp accepted this revision as: kp.Jan 13 2022, 9:13 AM

This revision is now accepted and ready to land.Jan 13 2022, 9:13 AM

glebius accepted this revision.Jan 13 2022, 4:47 PM

3f3e4f3c7472640aab998612a2253da95102345a

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

dn_sched_fq_pie.c

8 lines

Diff 101388

View Options

sys/netpfil/ipfw/dn_sched_fq_pie.c

dummynet: store current vnet when scheduling fqpie_callout_cleanupAbandonedPublicActions