Details

Reviewers

• rodrigc
theraven
wblock
bapt

Group Reviewers

manpages

Commits

rS286757: Make clear the bcopy(3) manpage regards when it was marked as LEGACY

Summary

The IEEE Std 1003.1-2008 (``POSIX.1'') removes the specification of

bcopy() and it is marked as LEGACY in IEEE Std 1003.1-2004 (``POSIX.1'')
New programs should use: memmove() if you can guarantee that the input
and output buffer do not overlap, then memcpy() would be more efficient.
Note that bcopy() takes its src and dst arguments in the opposite order
from memcpy() and memmove().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

araujo updated this revision to Diff 7918.Aug 13 2015, 6:56 AM

araujo retitled this revision from to Make clear the bcopy(3) man page, it is not obsolete..

araujo updated this object.

araujo edited the test plan for this revision. (Show Details)

Herald added a reviewer: manpages. · View Herald TranscriptAug 13 2015, 6:56 AM

Herald added a subscriber: imp. · View Herald Transcript

Just sort memmove and memcpy.

Herald edited edge metadata. · View Herald TranscriptAug 13 2015, 6:58 AM

Add @theraven suggestions.
Discussed on src-committers@.

Herald edited edge metadata. · View Herald TranscriptAug 13 2015, 8:08 AM

araujo retitled this revision from Make clear the bcopy(3) man page, it is not obsolete. to Make clear the bcopy(3) man page..Aug 13 2015, 8:09 AM

araujo updated this object.

araujo added reviewers: theraven, bapt, • rodrigc.

araujo removed a subscriber: theraven.

LGTM.

Just sort memmove and memcpy again.

Herald edited edge metadata. · View Herald TranscriptAug 13 2015, 8:28 AM

bapt accepted this revision.Aug 13 2015, 9:01 AM

bapt edited edge metadata.

wblock added a subscriber: wblock.Aug 13 2015, 12:17 PM

wblock added inline comments.

lib/libc/string/bcopy.3
85 ↗	(On Diff #7921)	No colon needed here.
87 ↗	(On Diff #7921)	Please avoid using "you", and this sentence is weird. The original has some trailing whitespace, too (please check with igor -R, which will check for those and other problems). Showing the suggested functions as .Xr references would be more helpful to the reader: New programs should use .Xr memmove 3 . If the input and output buffers do not overlap, .Xr memcpy 3 is more efficient.
93 ↗	(On Diff #7921)	takes .Ar src and .Ar dest in the

Address @wblock sugestions.
Also run:
igor -R
mandoc -Tlint

Thanks again @wblock.

Herald edited edge metadata. · View Herald TranscriptAug 13 2015, 2:02 PM

wblock added inline comments.Aug 13 2015, 3:40 PM

lib/libc/string/bcopy.3
85 ↗	(On Diff #7924)	I meant remove the colon (`:`). And "New" should be capitalized: New programs should use
89 ↗	(On Diff #7924)	"would be" is passive and sounds unsure, I suggest changing it to "is" (active). is more efficient.

Update with @wblocks suggestions.

Note that: the 'new' is keep in lower case, because
it continues in the sentence.

Herald edited edge metadata. · View Herald TranscriptAug 14 2015, 12:31 AM

araujo added inline comments.Aug 14 2015, 12:32 AM

lib/libc/string/bcopy.3
85 ↗	(On Diff #7938)	Here I kept the 'new' in lower case because the phrase didn't ends.

• rodrigc added inline comments.Aug 14 2015, 12:44 AM

lib/libc/string/bcopy.3
85 ↗	(On Diff #7938)	@wblock is correct. The previous sentence should end with a period. The next sentence should begin with new capitalized: New programs should use