tcp: Warning cleanup from new compiler.
ClosedPublic
Actions

Authored by rrs on Dec 15 2021, 3:32 PM.

Details

Reviewers

tuexen
glebius
lstewart

Group Reviewers

transport

Summary

The clang compiler recently got an update that generates warnings of unused
variables where they were set, and then never used. This revision goes through
the tcp stack and cleans all of those up.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

rrs created this revision.Dec 15 2021, 3:32 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptDec 15 2021, 3:32 PM

Herald added a subscriber: melifaro. · View Herald Transcript

rrs requested review of this revision.Dec 15 2021, 3:32 PM

tuexen accepted this revision.Dec 15 2021, 3:39 PM

This revision is now accepted and ready to land.Dec 15 2021, 3:39 PM

Clean up additionally some white space issues in rack.c

This revision now requires review to proceed.Dec 15 2021, 4:10 PM

tuexen accepted this revision.Dec 15 2021, 4:23 PM

This revision is now accepted and ready to land.Dec 15 2021, 4:23 PM

glebius accepted this revision.Dec 17 2021, 3:46 AM

rrs closed this revision.Jan 18 2022, 12:44 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_hpts.c

4 lines

tcp_ratelimit.c

2 lines

tcp_sack.c

3 lines

tcp_stacks/

bbr.c

23 lines

rack.c

125 lines

tcp_usrreq.c

2 lines

Diff 100080

View Options

sys/netinet/tcp_hpts.c

View Options

sys/netinet/tcp_ratelimit.c

View Options

sys/netinet/tcp_sack.c

View Options

sys/netinet/tcp_stacks/bbr.c

View Options

sys/netinet/tcp_stacks/rack.c

View Options

tcp: Warning cleanup from new compiler.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 100080

sys/netinet/tcp_hpts.c

sys/netinet/tcp_ratelimit.c

sys/netinet/tcp_sack.c

sys/netinet/tcp_stacks/bbr.c

sys/netinet/tcp_stacks/rack.c

sys/netinet/tcp_usrreq.c

tcp: Warning cleanup from new compiler.
ClosedPublic
Actions

Revision Contents
Changeset List