Page MenuHomeFreeBSD
Differential D33428

loader: move all gfx_fb.c stubs to common/gfx_fb_stub.c
ClosedPublic
Actions

Authored by imp on Dec 14 2021, 5:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 6:22 AM
Unknown Object (File)
Thu, Jan 23, 5:55 AM
Unknown Object (File)
Tue, Jan 21, 10:26 PM
Unknown Object (File)
Jan 18 2025, 11:15 PM
Unknown Object (File)
Jan 18 2025, 11:04 PM
Unknown Object (File)
Jan 18 2025, 6:41 PM
Unknown Object (File)
Dec 7 2024, 5:49 PM
Unknown Object (File)
Dec 2 2024, 9:22 AM
View All 59 Files
Subscribers
corvink
dab
rgrimes

Details

Reviewers
manu
loader
kevans
tsoome
Group Reviewers
bhyve
Commits
rG540a9f233431: loader: move all gfx_fb.c stubs to common/gfx_fb_stub.c
rG91d462192db0: loader: move all gfx_fb.c stubs to common/gfx_fb_stub.c
Summary

All these files are the same, modulo one comment. Move them all into
common/gfx_fb_stub.c and adjust Makefiles accordingly.

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43331
Build 40219: arc lint + arc unit

Event Timeline

imp created this revision.Dec 14 2021, 5:42 AM
Herald added a reviewer: manu. · View Herald TranscriptDec 14 2021, 5:42 AM
Herald added a reviewer: bhyve. · View Herald Transcript
Herald added subscribers: dab, rgrimes. · View Herald Transcript
imp requested review of this revision.Dec 14 2021, 5:42 AM
Harbormaster completed remote builds in B43331: Diff 99974.Dec 14 2021, 5:42 AM
imp added reviewers: loader, kevans, tsoome.Dec 14 2021, 5:45 AM
corvink added a subscriber: corvink.Dec 14 2021, 6:21 AM
corvink added inline comments.
stand/uboot/lib/Makefile
13
imp added inline comments.Dec 14 2021, 6:24 AM
stand/uboot/lib/Makefile
13

Yea, I caught that after upload...

manu accepted this revision.Dec 14 2021, 7:47 AM

With what Corvin noted fixed I'm good with this.

This revision is now accepted and ready to land.Dec 14 2021, 7:47 AM
Closed by commit rG91d462192db0: loader: move all gfx_fb.c stubs to common/gfx_fb_stub.c (authored by imp). · Explain WhyDec 14 2021, 10:28 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG91d462192db0: loader: move all gfx_fb.c stubs to common/gfx_fb_stub.c.
imp added a commit: rG540a9f233431: loader: move all gfx_fb.c stubs to common/gfx_fb_stub.c.Jan 24 2023, 10:22 PM

Revision Contents
Changeset List

PathSize
stand/
common/
gfx_fb_stub.c/
uboot/
lib/
gfx_fb.c
2 lines
powerpc/
kboot/
5 lines
ofw/
5 lines
uboot/
lib/
5 lines
userboot/
userboot/
4 lines

Diff 99974

View Options

stand/common/gfx_fb_stub.c

Loading...
View Options

stand/powerpc/kboot/Makefile

Loading...
View Options

stand/powerpc/kboot/gfx_fb.c

Loading...
View Options

stand/powerpc/ofw/Makefile

Loading...
View Options

stand/powerpc/ofw/gfx_fb.c

Loading...
View Options

stand/uboot/lib/Makefile

Loading...
View Options

stand/uboot/lib/gfx_fb.c

Loading...
View Options

stand/userboot/userboot/Makefile

Loading...
View Options

stand/userboot/userboot/gfx_fb.c

Loading...