Differential D33328

locator: Migrate to OO version of locator
AbandonedPublic
Actions

Authored by imp on Dec 8 2021, 1:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jan 1 2024, 12:17 AM

	Unknown Object (File)
	Nov 3 2023, 4:38 AM

	Unknown Object (File)
	Oct 1 2023, 4:37 AM

	Unknown Object (File)
	Sep 29 2023, 5:09 AM

	Unknown Object (File)
	May 20 2023, 6:03 PM

Subscribers

Details

Reviewers

Summary

Create an OO version of locator. Nicer, imho.

Sponsored by: Netflix

Test Plan

John: offered as the more oo version of this, less hacky. The code is a little longer, but should be easier to expand to new locators. It also dodges the 'which is more likely' discussions we were getting into wrt defaults.
I've just started testing this...

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	sys/sys/locator.h:50	SPELL1	Possible Spelling Mistake
Warning	sys/sys/locator.h:51	SPELL1	Possible Spelling Mistake
Warning	sys/sys/locator.h:52	SPELL1	Possible Spelling Mistake
Warning	sys/sys/locator.h:55	SPELL1	Possible Spelling Mistake
Warning	sys/sys/locator.h:56	SPELL1	Possible Spelling Mistake

Unit

No Test Coverage

Build Status

Buildable 43225
Build 40113: arc lint + arc unit

Event Timeline

imp created this revision.Dec 8 2021, 1:56 AM

Herald added a subscriber: dab. · View Herald TranscriptDec 8 2021, 1:56 AM

imp requested review of this revision.Dec 8 2021, 1:56 AM

Harbormaster completed remote builds in B43225: Diff 99685.Dec 8 2021, 1:56 AM

imp edited the test plan for this revision. (Show Details)Dec 8 2021, 1:58 AM

imp added a reviewer: jhb.

imp added inline comments.Dec 8 2021, 2:01 AM

sys/sys/kernel.h
140	I kinda think this is any time after locks are running. It can be after the discussed SI_SUB_BUS perhaps, but might be better before so that we can maybe wire things early? comments?

Also, commit message sucks and I need man pages.

imp abandoned this revision.Feb 16 2024, 3:35 AM

Revision Contents
Changeset List

Path

Size

sys/

conf/

1 line

dev/

acpica/

125 lines

15 lines

5 lines

iicbus/

2 lines

nvdimm/

2 lines

pci/

19 lines

6 lines

usb/

18 lines

12 lines

usb_hub_private.h

3 lines

kern/

19 lines

52 lines

229 lines

sys/

2 lines

1 line

71 lines

Diff 99685

sys/conf/files

Loading...

sys/dev/acpica/acpi.c

Loading...

sys/dev/acpica/acpi_pci.c

Loading...

sys/dev/acpica/acpivar.h

Loading...

sys/dev/iicbus/acpi_iicbus.c

Loading...

sys/dev/nvdimm/nvdimm_acpi.c

Loading...

sys/dev/pci/pci.c

Loading...

sys/dev/pci/pci_private.h

Loading...

sys/dev/usb/usb_hub.c

Loading...

sys/dev/usb/usb_hub_acpi.c

Loading...

sys/dev/usb/usb_hub_private.h

Loading...

sys/kern/bus_if.m

Loading...

sys/kern/subr_bus.c

Loading...

sys/kern/subr_locator.c

Loading...

sys/sys/bus.h

Loading...

sys/sys/kernel.h

Loading...

sys/sys/locator.h

Loading...