Page MenuHomeFreeBSD
Differential D3319

Add support to read arm64 minidumps to libkvm
ClosedPublic
Actions

Authored by andrew on Aug 6 2015, 3:32 PM.
Tags
None
Referenced Files
F81642292: D3319.id7717.diff
Fri, Apr 19, 9:37 AM
Unknown Object (File)
Fri, Apr 19, 2:47 AM
Unknown Object (File)
Fri, Mar 29, 8:14 AM
Unknown Object (File)
Tue, Mar 26, 3:06 AM
Unknown Object (File)
Mar 18 2024, 2:11 PM
Unknown Object (File)
Mar 18 2024, 2:10 PM
Unknown Object (File)
Mar 18 2024, 2:10 PM
Unknown Object (File)
Mar 18 2024, 1:58 PM
View All Files
Subscribers
emaste
imp

Details

Reviewers
peter
jhb
Group Reviewers
arm64
Commits
rS286953: Add support to libkvm for reading minidumps on arm64. The kernel side is
Summary

This has been developed against D3318 to make sure we can read the data
from the dump, and it contains all the information we need.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

andrew updated this revision to Diff 7717.Aug 6 2015, 3:32 PM
andrew retitled this revision from to Add support to read arm64 minidumps to libkvm.
andrew updated this object.
andrew edited the test plan for this revision. (Show Details)
andrew added reviewers: arm64, jhb, peter.
Herald added subscribers: emaste, imp. · View Herald TranscriptAug 6 2015, 3:32 PM
jhb edited edge metadata.Aug 6 2015, 4:16 PM

This should be easy to convert for my changes. Do you intend to only support minidumps or will you also support full dumps at some point?

jhb added a comment.Aug 6 2015, 4:16 PM

Also, FYI, in my branch some of the boilerplate will go away (all the hpte stuff is now shared for example).

andrew added a comment.Aug 6 2015, 4:37 PM
In D3319#67291, @jhb wrote:

Do you intend to only support minidumps or will you also support full dumps at some point?

I have no immediate plans to support full dumps.

emaste added a comment.Aug 6 2015, 5:19 PM
In D3319#67303, @andrew wrote:

I have no immediate plans to support full dumps.

FWIW I have no problem with us supporting only minidumps.

jhb added a comment.Aug 6 2015, 5:28 PM

Mostly just curious. We did have a few panics at Y! for which full dumps were useful (you could examine user memory), but those are generally rare.

jhb accepted this revision.Aug 6 2015, 5:28 PM
jhb edited edge metadata.
This revision is now accepted and ready to land.Aug 6 2015, 5:28 PM
emaste mentioned this in D3341: Add support for cross-arch vmcores..Aug 12 2015, 5:59 PM
Closed by commit rS286953: Add support to libkvm for reading minidumps on arm64. The kernel side is (authored by andrew). · Explain WhyAug 20 2015, 11:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
libkvm/
57 lines
269 lines
4 lines

Diff 7717

View Options

lib/libkvm/kvm_aarch64.c

Loading...
View Options

lib/libkvm/kvm_minidump_aarch64.c

Loading...
View Options

lib/libkvm/kvm_private.h

Loading...