Remove options VESA from x86 GENERIC
ClosedPublic
Actions

Authored by emaste on Nov 27 2021, 8:46 PM.

Details

Reviewers

tsoome
imp
manu

Commits

rGb8cf1c5c30a5: Remove options VESA from x86 GENERIC

Summary

VESA is supported only by the legacy sc(4) console driver, not vt(4). As reported on the freebsd-hackers list[1] having VESA compiled into
the kernel or loaded as a module can cause issues with suspend/resume when the nvidia driver is in use.

Since VESA currently serves no purpose with vt(4), remove it from GENERIC and allow sc(4) users who need it to load it as a module. (It may still be worth adding VESA support to vt(4); we can revisit this change if that occurs.)

[1] https://lists.freebsd.org/archives/freebsd-hackers/2021-November/000469.html

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Nov 27 2021, 8:46 PM

emaste created this revision.

Clarification, options VESA and vesa.ko is supported only by sc(4). a4a10b37d422dcdff2b0d700ab073b3078627a08 added vt_vbefb but it does not use vesa.ko and doesn't support mode switching, it just supports the VBE mode left in place by the loader.

tsoome accepted this revision.Nov 27 2021, 9:25 PM

This revision is now accepted and ready to land.Nov 27 2021, 9:25 PM

emaste added reviewers: imp, manu.Nov 27 2021, 9:37 PM

imp accepted this revision.Nov 27 2021, 9:50 PM

manu accepted this revision.Nov 28 2021, 9:50 AM

Closed by commit rGb8cf1c5c30a5: Remove options VESA from x86 GENERIC (authored by emaste). · Explain WhyNov 28 2021, 4:38 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGb8cf1c5c30a5: Remove options VESA from x86 GENERIC.