efiloader: shuffle reboot functionality into libefi
AcceptedPublic
Actions

Authored by kevans on Oct 25 2021, 2:28 AM.

Details

Reviewers

tsoome
imp
bcran

Summary

A later change will want to "properly" reboot (i.e. cleanup devsw
bits), so move it there now. A devsw stub is added to boot1 to keep
it linking successfully; libefi already uses the devsw global in
places, but apparently these bits are not used in the final link.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42335
Build 39223: arc lint + arc unit

Event Timeline

kevans created this revision.Oct 25 2021, 2:28 AM

Herald added a subscriber: dab. · View Herald TranscriptOct 25 2021, 2:28 AM

kevans requested review of this revision.Oct 25 2021, 2:28 AM

Harbormaster completed remote builds in B42335: Diff 97380.Oct 25 2021, 2:28 AM

kevans added a child revision: D32634: efiloader: add an `efi-setup` command.Oct 25 2021, 2:28 AM

imp added inline comments.Oct 25 2021, 2:50 AM

stand/efi/libefi/libefi.c
66	I think this is a layering violation... devsw is generally unknown to libefi and to most of the other interfaces to boot loader libraries. I'm unsure of a better way.

kevans added inline comments.Oct 25 2021, 2:52 AM

stand/efi/libefi/libefi.c
66	We had committed this sin once in devicename.c already; no objection to just moving this back and putting the new command proper into loader/, though

imp accepted this revision.Oct 25 2021, 3:15 AM

imp added inline comments.

stand/efi/libefi/libefi.c
66	Ah, all that's moving up is knowing that a devsw exists... The struct devsw is widely used itself, so it's less bad than I thought. So no objections...