Differential D32596

bhyve: do not explicitly map fbuf framebuffer
ClosedPublic
Actions

Authored by c.koehne_beckhoff.com on Oct 22 2021, 9:32 AM.

Details

Reviewers

grehan
manu

Group Reviewers

Commits

R10:e5fb2bbad268: bhyve: do not explicitly map fbuf framebuffer
R10:5085153ae4d5: bhyve: do not explicitly map fbuf framebuffer

Summary

Allocating a BAR will call baraddr which maps the framebuffer. No need
to allocate it explicitly on init.

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

c.koehne_beckhoff.com created this revision.Oct 22 2021, 9:32 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptOct 22 2021, 9:32 AM

c.koehne_beckhoff.com requested review of this revision.Oct 22 2021, 9:32 AM

Works fine.

Was this a general fix, or part of some larger future work ?

This revision is now accepted and ready to land.Oct 25 2021, 11:57 AM

Just a general fix.

c.koehne_beckhoff.com added a reviewer: manu.Nov 17 2021, 11:26 AM

Closed by commit R10:5085153ae4d5: bhyve: do not explicitly map fbuf framebuffer (authored by c.koehne_beckhoff.com, committed by manu). · Explain WhyNov 18 2021, 3:29 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: R10:5085153ae4d5: bhyve: do not explicitly map fbuf framebuffer.

manu added a commit: R10:e5fb2bbad268: bhyve: do not explicitly map fbuf framebuffer.Jan 14 2022, 2:21 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

32 lines

Diff 97278

usr.sbin/bhyve/pci_fbuf.c

Loading...