Ensure that sys/sysctl.h can be included standalone.
Sponsored by: Netflix
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 42139 Build 39027: arc lint + arc unit
Event Timeline
| tests/sys/sys/sysctl_h_self.c | ||
|---|---|---|
| 14 | But what about headers that might be included by atf-c.h? Can't this just be a standalone C program, not using ATF at all? Also this is testing the build, not the installed system. I could drop this test on a system where sysctl.h depends on other headers and it'd pass. Perhaps the right form for this test is a shell script which tries to compile a small C program a la autoconf. | |
| tests/sys/sys/sysctl_h_self.c | ||
|---|---|---|
| 14 |
Sure. Since I included it first.
But I like that better. I'll rework with that. | |
Comment Actions
I'm torn... on the one hand I like the idea of building this during MK_TESTS=yes because the build will fail if you break it.
On the other hand, I like being able to test the target system.
I'd personally lean towards breaking the build of the tests, but I'm easy.
Comment Actions
There are/were other facilities in ATF that supported compile-time testing, but I think they should be removed, not expanded on.
Maybe it makes sense to instead run cpp and look at the headers output instead of doing this?
Comment Actions
Also, this seems like (and I'm going to regret saying this) something that a system like autoconf might excel at (*shudders*).
Comment Actions
It's because of lame autoconf systems that make lame assumptions that I'm doing this... the tests im adding won't be in atf: they will be part of buildworld...