Page MenuHomeFreeBSD
Differential D32479

sys/conf: move libfdt path inclusion to kern.pre.mk
Needs ReviewPublic
Actions

Authored by ehem_freebsd_m5p.com on Oct 13 2021, 2:53 PM.
Tags
None
Referenced Files
F81427951: D32479.diff
Tue, Apr 16, 5:16 AM
Unknown Object (File)
Dec 20 2023, 7:53 AM
Unknown Object (File)
Dec 19 2023, 6:39 PM
Unknown Object (File)
Nov 1 2023, 7:11 PM
Unknown Object (File)
Sep 11 2023, 5:19 PM
Unknown Object (File)
Sep 10 2023, 4:38 AM
Unknown Object (File)
Aug 27 2023, 8:11 PM
Unknown Object (File)
Aug 25 2023, 6:06 PM
View All 11 Files
Subscribers
andrew
emaste
imp
Contributor Reviews (src)
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

As all architectures now include libfdt, it should be in the common
Makefile, rather than duplicated in every architecture.

Switch to per-library include lines, the better to make future
adjustments smaller and simpler.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42104
Build 38992: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Oct 13 2021, 2:53 PM
Herald added subscribers: Contributor Reviews (src), emaste, andrew, imp. · View Herald TranscriptOct 13 2021, 2:53 PM
ehem_freebsd_m5p.com requested review of this revision.Oct 13 2021, 2:53 PM
Harbormaster completed remote builds in B42104: Diff 96811.Oct 13 2021, 2:53 PM
ehem_freebsd_m5p.com updated this revision to Diff 97271.Oct 22 2021, 5:08 AM

Updating in light of commit 8e53cd709943.

Harbormaster completed remote builds in B42296: Diff 97271.Oct 22 2021, 5:08 AM
imp added inline comments.Oct 22 2021, 5:34 AM
sys/conf/Makefile.amd64
34

This line can be removed here and elsewhere.

ehem_freebsd_m5p.com added inline comments.Oct 23 2021, 2:47 AM
sys/conf/Makefile.amd64
34

True. I thought it better to leave the empty line behind to keep the Makefile.<arch> files more consistent with each other (in case a new include needs to be added). Perhaps leave as commented lines?

I don't have strong feelings on this though, feel free to simply nuke the lines on commit.

Revision Contents
Changeset List

PathSize
sys/
conf/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
4 lines

Diff 96811

View Options

sys/conf/Makefile.amd64

Loading...
View Options

sys/conf/Makefile.arm

Loading...
View Options

sys/conf/Makefile.arm64

Loading...
View Options

sys/conf/Makefile.i386

Loading...
View Options

sys/conf/Makefile.mips

Loading...
View Options

sys/conf/Makefile.powerpc

Loading...
View Options

sys/conf/Makefile.riscv

Loading...
View Options

sys/conf/kern.pre.mk

Loading...