Page MenuHomeFreeBSD

devel/desktop-file-utils: use trigger
Needs ReviewPublic

Authored by bapt on Mon, Oct 11, 8:02 AM.

Details

Reviewers
tcberner
manu
Group Reviewers
portmgr
Summary

Instead of polluting all files with a script to be executed post install
convert the handling of mime database into a trigger

This trigger will regenerate the db each time someone install a files
into the concern directory

On removal of the desktop-file-utils port, it will cleanup its cache.

While here convert the post installation script into a lua script.
Note the db is always run at post installation of the port, just to make
sure the cache is up to date, in case the format changes in the futur

desktop-file-utils: remove the keyword it is not necessary anymore

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 42266
Build 39154: arc lint + arc unit

Event Timeline

bapt requested review of this revision.Mon, Oct 11, 8:02 AM
devel/desktop-file-utils/Makefile
19

Maybe it's me, but I don't see that file here.

bapt marked an inline comment as done.Wed, Oct 20, 9:14 AM
bapt added inline comments.
devel/desktop-file-utils/Makefile
19

the sub_files was missing

devel/desktop-file-utils/Makefile
20–21

So, mmm, SUB_FILES will create a WRKDIR/pkg-post-install.lua, not a WRKDIR/pkg-post-install, is the .lua somewhat magic, like, if it's there, or not, it does not matter?