Page MenuHomeFreeBSD

devel/desktop-file-utils: use trigger
ClosedPublic

Authored by bapt on Oct 11 2021, 8:02 AM.

Details

Reviewers
tcberner
manu
bapt
Group Reviewers
portmgr
Summary

Instead of polluting all files with a script to be executed post install
convert the handling of mime database into a trigger

This trigger will regenerate the db each time someone install a files
into the concern directory

On removal of the desktop-file-utils port, it will cleanup its cache.

While here convert the post installation script into a lua script.
Note the db is always run at post installation of the port, just to make
sure the cache is up to date, in case the format changes in the futur

desktop-file-utils: remove the keyword it is not necessary anymore

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 42266
Build 39154: arc lint + arc unit

Event Timeline

bapt requested review of this revision.Oct 11 2021, 8:02 AM
devel/desktop-file-utils/Makefile
20

Maybe it's me, but I don't see that file here.

bapt marked an inline comment as done.Oct 20 2021, 9:14 AM
bapt added inline comments.
devel/desktop-file-utils/Makefile
20

the sub_files was missing

devel/desktop-file-utils/Makefile
20–21

So, mmm, SUB_FILES will create a WRKDIR/pkg-post-install.lua, not a WRKDIR/pkg-post-install, is the .lua somewhat magic, like, if it's there, or not, it does not matter?

bapt added inline comments.
devel/desktop-file-utils/Makefile
20–21

the .lua tells pkg it should expect a lua script and not a shell script.

This revision is now accepted and ready to land.Nov 17 2021, 12:51 PM