default_unit is a clearer name.
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Can you also update the Symbol versioning file with the new symbol, while not removing the old one!
MLINKS+= needs an update too.
In the C-code you need to add:
symver(mixer_get_default_unit, mixer_get_dunit, FBSD_1.7); symver(mixer_set_default_unit, mixer_set_dunit, FBSD_1.7);
From now on, such changes must be backwards compatible.
lib/libmixer/Symbol.map | ||
---|---|---|
18 | mixer_get/set_dunit must remain. You can only add stuff. |
Since the library is so new, do we need to do this and not just rename the
symbols to keep it clean, at least this time?
Since the library is so new, do we need to do this and not just rename the
symbols to keep it clean, at least this time?
I see this more of an exercise for you.
The problem is that 3rd parties may already be using this stuff, even though it has just existed for a week, and I don't want to continue breaking stuff :-)
This is what makes FreeBSD great sometimes.
--HPS
I think "dunit" is just as good as "default_unit".
BTW: It is possible to make one differential revision depend on another.
I see now, this one was supposed to go first, then the other one which broke buildworld.
If it is, we can keep it as is then, I don't mind personally.
BTW: It is possible to make one differential revision depend on another.
I see now, this one was supposed to go first, then the other one which broke buildworld.
Yeap, exactly.
BTW: If you first expand dunit -> default_unit, there are many other function names you should treat the same:
nmixers->num_mixers ?
recsrc -> recording_source
????
Also, people should read the manual page. Then the function name is not that important.