Page MenuHomeFreeBSD
Differential D32037

Remove remaining references to VM_ALLOC_NOOBJ
ClosedPublic
Actions

Authored by markj on Sep 21 2021, 2:45 AM.
Tags
None
Referenced Files
F81538151: D32037.diff
Wed, Apr 17, 5:46 PM
Unknown Object (File)
Mar 3 2024, 1:33 AM
Unknown Object (File)
Mar 3 2024, 1:33 AM
Unknown Object (File)
Mar 3 2024, 1:33 AM
Unknown Object (File)
Mar 3 2024, 1:29 AM
Unknown Object (File)
Mar 3 2024, 1:29 AM
Unknown Object (File)
Mar 3 2024, 1:29 AM
Unknown Object (File)
Mar 3 2024, 1:10 AM
View All 50 Files
Subscribers
imp

Details

Reviewers
alc
kib
Commits
rGa9d6f1fe0a2f: Remove some remaining references to VM_ALLOC_NOOBJ

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Sep 21 2021, 2:45 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 21 2021, 2:45 AM
markj requested review of this revision.Sep 21 2021, 2:45 AM
Harbormaster completed remote builds in B41615: Diff 95418.Sep 21 2021, 2:45 AM
markj added a parent revision: D32036: vm_fault: Stop specifying VM_ALLOC_ZERO.Sep 21 2021, 2:45 AM
kib added inline comments.Sep 21 2021, 12:51 PM
sys/vm/vm_page.h
545

I would leave this flag under some name like VM_AVAIL0, mostly because all flags bits are already consumed.

kib accepted this revision.Sep 21 2021, 12:51 PM
This revision is now accepted and ready to land.Sep 21 2021, 12:51 PM
markj updated this revision to Diff 95448.Sep 21 2021, 2:03 PM
markj marked an inline comment as done.

Add placeholder flags.

This revision now requires review to proceed.Sep 21 2021, 2:03 PM
markj added inline comments.Sep 21 2021, 2:03 PM
sys/vm/vm_page.h
545

0x800 is unused too.

Harbormaster completed remote builds in B41619: Diff 95448.Sep 21 2021, 2:04 PM
kib accepted this revision.Sep 21 2021, 2:19 PM
This revision is now accepted and ready to land.Sep 21 2021, 2:19 PM
alc added inline comments.Sep 23 2021, 5:55 PM
sys/vm/uma.h
486–487

I think that we should have a different word, not "anonymous", to describe these pages. Most so-called "anonymous memory" consists of pages that belong to VM objects.

markj added inline comments.Sep 24 2021, 4:08 PM
sys/vm/uma.h
486–487

Perhaps "unnamed"? Elsewhere we refer to the <object, pindex> tuple of a page as its "identity", so some adjective similar to "anonymous" seems appropriate.

markj updated this revision to Diff 96118.Oct 1 2021, 10:01 PM

Use "unnamed" instead of "anonoymous"

This revision now requires review to proceed.Oct 1 2021, 10:01 PM
Harbormaster completed remote builds in B41910: Diff 96118.Oct 1 2021, 10:01 PM
alc accepted this revision.Oct 17 2021, 6:34 PM
alc added inline comments.
sys/vm/uma.h
486–487

We are not space constrained here, i.e., we are not trying to come up with a short phrase that fits on the same as a #define, so I would argue that we unambiguously spell out what we mean.

This revision is now accepted and ready to land.Oct 17 2021, 6:34 PM
markj updated this revision to Diff 97017.Oct 17 2021, 8:49 PM

Try to make the uma_reserve_kva() clearer: don't mention VM objects
at all since it doesn't really make sense to mention such details
in a public header. Fix the comment above noobj_alloc().

This revision now requires review to proceed.Oct 17 2021, 8:49 PM
Harbormaster completed remote builds in B42201: Diff 97017.Oct 17 2021, 8:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 20 2021, 1:24 AM
Closed by commit rGa9d6f1fe0a2f: Remove some remaining references to VM_ALLOC_NOOBJ (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGa9d6f1fe0a2f: Remove some remaining references to VM_ALLOC_NOOBJ.

Revision Contents
Changeset List

PathSize
sys/
vm/
3 lines
2 lines
3 lines

Diff 97145

View Options

sys/vm/uma.h

Loading...
View Options

sys/vm/uma_core.c

Loading...
View Options

sys/vm/vm_page.h

Loading...