Page MenuHomeFreeBSD

biology/jellyfish: Fix build when NLS knob is off
ClosedPublic

Authored by jrm on Sep 16 2021, 4:53 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 41543
Build 38432: arc lint + arc unit

Event Timeline

jrm requested review of this revision.Sep 16 2021, 4:53 PM

Switch to static tarball and update license info

Rather than forcing gettext regardless whether the NLS know is off, switch to the static tarball suplied by upstream. This has the advantage that we won't get hit by the rare, but annoying rerolling of the automatic GitHub tarballs.

Thanks for the heads-up. I'm not inclined to trust a hand-rolled distfile when the only benefit is avoiding an autoreconf, though. I'll commit the NLS and license changes ASAP.

The previous commit here does that. But, the contributed tarballs are often preferred, because GitHub and GitLab's automatically generated tarballs are not guaranteed to be static. Here is one example and it may be becoming more of a problem lately. The user-generated tarballs also may not be manually generated. Some CI tools create them for the releases.

Interesting. I've personally never been hit by a Github tarball reroll, so I'm not too concerned. I'll commit without the static tarball change for now and investigate this further when I can make some time for proper regression testing.

Incorporate changes from jwb (via email)

This revision is now accepted and ready to land.Sep 17 2021, 5:39 PM