efi: switch boot_services_gone to boot_services_active
ClosedPublic
Actions

Authored by imp on Sep 3 2021, 3:06 AM.

Details

Reviewers

tsoome
kib
kevans
manu

Commits

rGc8e7050f8a6a: efi: switch boot_services_gone to boot_services_active
rG305ef653bcf3: efi: switch boot_services_gone to boot_services_active

Summary

Turn the presence or absence of boot services into a positive bool (and
change its type to bool). Move definition to efi.h in the global
variables section.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Sep 3 2021, 3:06 AM

Herald added subscribers: dab, bcran. · View Herald TranscriptSep 3 2021, 3:06 AM

imp requested review of this revision.Sep 3 2021, 3:06 AM

Harbormaster completed remote builds in B41345: Diff 94601.Sep 3 2021, 3:06 AM

imp added reviewers: tsoome, kib, kevans.Sep 3 2021, 3:08 AM

Thanks!

This revision is now accepted and ready to land.Sep 3 2021, 8:41 AM

What I like about the _gone name is that it makes it quite clear that switch from has_boot_services = true to false is one-time event. You cannot get services back once they are gone.

IMO it was a useful and important detail communicated by the name.

stand/efi/include/efi.h
63	Does stdbool.h work for loader environment?

imp retitled this revision from efi: switch boot_services_gone to has_boot_services to efi: switch boot_services_gone to boot_services_active.Sep 29 2021, 4:07 PM

Move to boot_services_active
It's the positive version of _gone and conveys the same meaning.

This revision now requires review to proceed.Sep 29 2021, 4:08 PM

Harbormaster completed remote builds in B41843: Diff 95952.Sep 29 2021, 4:08 PM

kib accepted this revision.Sep 30 2021, 2:29 AM

kib added inline comments.