Page MenuHomeFreeBSD
Differential D31630

Correct nh_family
AbandonedPublic
Actions

Authored by zlei on Aug 21 2021, 3:27 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Apr 17, 8:14 PM
Unknown Object (File)
Jan 8 2024, 10:41 PM
Unknown Object (File)
Jan 1 2024, 12:05 AM
Unknown Object (File)
Dec 21 2023, 9:48 AM
Unknown Object (File)
Nov 5 2023, 5:29 PM
Unknown Object (File)
Nov 1 2023, 10:58 PM
Unknown Object (File)
Oct 23 2023, 2:29 PM
Unknown Object (File)
Oct 4 2023, 4:28 PM
View All 16 Files
Subscribers
ae

Details

Reviewers
melifaro
Summary

The nh_family should be address family of route's nexthop.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei created this revision.Aug 21 2021, 3:27 PM
Herald added a subscriber: ae. · View Herald TranscriptAug 21 2021, 3:27 PM
zlei requested review of this revision.Aug 21 2021, 3:27 PM
melifaro added a comment.Aug 21 2021, 6:33 PM

It's a bit more complex than that.
For the interface routes (e.g. ones w/o the gateway), you may end up with AF_LINK family in RTAX_GATEWAY.
So, you need to check if RTF_GATEWAY is set prior to using RTAX_GATEWAY.

melifaro added a comment.Aug 22 2021, 3:34 PM

I'd rather not touch it now - there is something WIP that will change this part of the code anyway.

zlei abandoned this revision.Aug 23 2021, 2:45 AM
In D31630#713490, @melifaro wrote:

I'd rather not touch it now - there is something WIP that will change this part of the code anyway.

OK.

Revision Contents
Changeset List

PathSize
sys/
net/
route/
2 lines

Diff 94000

View Options

sys/net/route/nhop_ctl.c

Loading...