fontconfig: Restore generation of cache prior to Meson switch

[diizzy]

Summary

This should fix PR 254963 and restore previous behaviour which accidentally got overlooked during the conversion.

Test Plan

Poudriere testport OK 12.2-RELEASE (amd64)

[arrowd]

x11-fonts/fontconfig/files/patch-fc-cache_meson.build

8

Why this patch is needed? The condition should always be true when building from Ports, as we don't support cross-compilation.

[diizzy]

Use SUB_ functions instead manually invoking sed (pointed out by tcberner)

[diizzy]

x11-fonts/fontconfig/files/patch-fc-cache_meson.build

8

This seem to cause permission issues when builing as non root https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254963

[arrowd]

x11-fonts/fontconfig/files/patch-fc-cache_meson.build

8

Hum, I wonder if the setting $HOME (to, say, ${WRKDIR}/home) would make it work. If it does, I like this solution more, as it doesn't involve patching.

[diizzy]

x11-fonts/fontconfig/files/patch-fc-cache_meson.build

8

Not sure I follow you, paths are set here:
https://cgit.freebsd.org/ports/tree/x11-fonts/fontconfig/Makefile#n29
https://cgit.freebsd.org/ports/tree/x11-fonts/fontconfig/files/patch-meson.build
and I don't see how setting $HOME would override it?

[diizzy]

Fix typo, depdency --> dependency

[arrowd]

x11-fonts/fontconfig/files/patch-fc-cache_meson.build

8

AFAIK, fc-cache tries to write cache files into system directories first and then into $HOME/.cache or something like that. Providing a writable home directory during the build may probably workaround the failure we see.

[diizzy]

Alternative patch for fontconfig to work around this issue can be found here:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254963#c9
https://gitlab.freedesktop.org/fontconfig/fontconfig/-/issues/296
Is that a better approach?

[arrowd]

In D31602#716683, @diizzy wrote:

Alternative patch for fontconfig to work around this issue can be found here:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254963#c9
https://gitlab.freedesktop.org/fontconfig/fontconfig/-/issues/296
Is that a better approach?

Yep, this is the best solution.

[diizzy]

Use patch submitted upstream by John Hein (converted using make makepatch)
https://gitlab.freedesktop.org/fontconfig/fontconfig/-/issues/296