Page MenuHomeFreeBSD
Differential D31212

Fix issue with RACK/BBR when VIMAGE is enabled
ClosedPublic
Actions

Authored by tuexen on Jul 18 2021, 10:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 9:23 PM
Unknown Object (File)
Fri, Apr 19, 11:25 PM
Unknown Object (File)
Wed, Apr 17, 9:09 PM
Unknown Object (File)
Mar 7 2024, 8:00 PM
Unknown Object (File)
Jan 31 2024, 7:53 AM
Unknown Object (File)
Jan 27 2024, 11:39 AM
Unknown Object (File)
Jan 27 2024, 10:25 AM
Unknown Object (File)
Jan 18 2024, 11:06 PM
View All 26 Files
Subscribers
melifaro
mjg

Details

Reviewers
rrs
Group Reviewers
transport
Commits
rG9b1219b24a5a: tcp: fix RACK and BBR when using VIMAGE enabled kernel
rGa730d82378d3: tcp: fix RACK and BBR when using VIMAGE enabled kernel
Summary

CURVNET_RESTORE expands to multiple expressions. So enclose it in curly brackets when used in an if statement.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tuexen created this revision.Jul 18 2021, 10:01 AM
Herald added a reviewer: transport. · View Herald TranscriptJul 18 2021, 10:01 AM
Herald added a subscriber: melifaro. · View Herald Transcript
tuexen requested review of this revision.Jul 18 2021, 10:01 AM
mjg added a subscriber: mjg.Jul 18 2021, 3:40 PM

why not fix curvnet macros?

tuexen added a comment.Jul 18 2021, 4:49 PM
In D31212#702735, @mjg wrote:

why not fix curvnet macros?

Are they broken? I guess you can change them for CURVNET_RESTORE, but not for CURVNET_SET. So I guess they are done this way for consistency... But I don't know for sure, since I did not invent them...

The man page explicitly state that

if (condition)
        CURVNET_SET(vnet);

will not work, but it does not say anything regarding CURVNET_RESTORE.

rrs accepted this revision.Jul 19 2021, 6:26 PM
This revision is now accepted and ready to land.Jul 19 2021, 6:26 PM
mjg added a comment.Jul 19 2021, 9:19 PM

The need to guard their use with { } is most definitely a bug and will keep tripping people over.

Looking at the code I have to say I don't see a fix which does not induce churn. If the set/restore macros took an argument we would be set, but it's definitely not something I'm going to spend time on nor will demand someone else does.

Closed by commit rGa730d82378d3: tcp: fix RACK and BBR when using VIMAGE enabled kernel (authored by tuexen). · Explain WhyJul 19 2021, 10:33 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGa730d82378d3: tcp: fix RACK and BBR when using VIMAGE enabled kernel.
tuexen added a commit: rG9b1219b24a5a: tcp: fix RACK and BBR when using VIMAGE enabled kernel.Jul 22 2021, 9:14 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
tcp_stacks/
6 lines

Diff 92394

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

Loading...