libvmm: remove unused enum vm_mmap_style argument from vm_setup_memory()

[rew]

Summary

This enum became unused when support for devmem was introduced in
9b1aa8d622e84cde39 (svn: r284539).

[markj]

lib/libvmmapi/vmmapi.h

121

This technically breaks compatibility with external consumers (i.e., bhyve(8) and bhyveload(8)). In practice I suspect it's mostly harmless since old executables will pass an extra parameter which gets ignored. On amd64 at least this is usually ok.

OTOH, I'm not sure that this kind of change is warranted just for some minor simplification. It might be useful to add new "styles" in the future, so it would be convenient to keep this extra parameter around to avoid having to bump SHLIB_MAJOR later.

I don't have a strong feeling either way but just wanted to point out that this change has some implications beyond simple cleanup.

[rew]

Thanks for the feedback - good info there, I'll consider those points when I consider (other) changes in the future.

I'll let this revision go.