lang/python*: Replace DISABLED_EXTENSIONS with Setup.local
ClosedPublic
Actions

Authored by dbaio on Jul 7 2021, 2:07 AM.

Details

Reviewers

Group Reviewers

Commits

R11:42b74dbb33b8: lang/python*: Replace DISABLED_EXTENSIONS with Setup.local
R11:a94d4b1005b1: lang/python*: Replace DISABLED_EXTENSIONS with Setup.local

Summary

lang/python*: Replace DISABLED_EXTENSIONS with Setup.local

Currently, lang/python38 and lang/python39 don't honour
DISABLED_EXTENSIONS because patch-issue20210 was removed when
lang/python38 was added to the ports tree. patch-issue20210 is
still present on lang/python36 and lang/python37.

Building with poudriere is not affected because builds are executed
in a clean environment.

Setup.local is the more canonical and recommended method for
customising python builds for shared extensions & third party
libraries.

Support for a *disabled* marker in Setup files was introduced in Python
3.7, so backport this fix to it to keep consistency in the ports tree.

PR:		243358 [1]
PR:		243937 [2]
Reported by:	ngie [1]
Reported by:	jcfyecrayz@liamekaens.com [2]
Reported by:	tuxillo (IRC) DPorts
Reviewed_by:    koobs (python, maintainer)
Approved by:    koobs, danilo (python, maintainer)
MFH:            2020Q3 (build bugfix)

Test Plan

testport: OK (poudriere, lang/python??, $modules tested)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dbaio created this revision.Jul 7 2021, 2:07 AM

Herald added a subscriber: mat. · View Herald TranscriptJul 7 2021, 2:07 AM

dbaio requested review of this revision.Jul 7 2021, 2:07 AM

Harbormaster completed remote builds in B40361: Diff 91919.Jul 7 2021, 2:07 AM

koobs added a reviewer: Python.Jul 7 2021, 2:31 AM

koobs edited the summary of this revision. (Show Details)

Change looks good. Can we confirm successful QA for the three supported modules, by forcing BUILD_DEPENDS on them so it can be tested in poudriere

In D31086#699349, @koobs wrote:

Change looks good. Can we confirm successful QA for the three supported modules, by forcing BUILD_DEPENDS on them so it can be tested in poudriere

Thanks koobs... And yes, it's all good on my tests.
I'll push it.