Details

Reviewers

jhb
allanjude
bdrewery
manu

Commits

rGb455c74d83e3: mk: WITH_FOO=no now generates a warning
rGa314e842d375: mk: WITH_FOO=no now generates a warning
rGf4d987cd137c: mk: WITH_FOO=no now generates a warning

Summary

Many people are used to gnu configure's behavior of changing
--with-foo=no to --without-foo. At the same time, several folks have
WITH_FOO=no in their config files to enable this ironic form of the
option because of an old meme from IRC, a mailing list or the forums (I
forget which). Add a warning to allow to alert people w/o breaking POLA.

MFC After: 2 weeks
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jun 7 2021, 8:00 PM

Herald added subscribers: emaste, bdrewery. · View Herald TranscriptJun 7 2021, 8:00 PM

imp requested review of this revision.Jun 7 2021, 8:00 PM

Harbormaster completed remote builds in B39775: Diff 90543.Jun 7 2021, 8:00 PM

imp added a reviewer: jhb.Jun 7 2021, 8:00 PM

LGTM

This revision is now accepted and ready to land.Jun 7 2021, 8:01 PM

manu added a subscriber: manu.Jun 7 2021, 8:02 PM

manu added inline comments.

share/mk/bsd.mkopt.mk
40	If you put -D at one place you should put it in the other. But I think that we shouldn't .warning with -D here, as we have redirected people to use src.conf for a long time now.

both cases

This revision now requires review to proceed.Jun 7 2021, 9:01 PM

Harbormaster completed remote builds in B39777: Diff 90546.Jun 7 2021, 9:02 PM

tweak warning message, per manu@

Harbormaster completed remote builds in B39778: Diff 90547.Jun 7 2021, 9:02 PM

imp marked an inline comment as done.Jun 7 2021, 9:03 PM

imp added inline comments.

share/mk/bsd.mkopt.mk
40	sure. updated comment

manu added inline comments.Jun 7 2021, 9:07 PM

share/mk/bsd.mkopt.mk
61	There is a '-' that shouldn't be there :)

bdrewery added inline comments.Jun 7 2021, 9:30 PM

share/mk/bsd.mkopt.mk
40	Doesn't `WITHOUT_FOO=<yes>` perpetuate the wrong idea?
63	What if they have `WITHOUT_FOO=no`?

better message

Harbormaster completed remote builds in B39782: Diff 90551.Jun 7 2021, 9:49 PM

imp added inline comments.Jun 7 2021, 9:53 PM

share/mk/bsd.mkopt.mk
40	changed it to be generic.
63	I'm unsure on this point. WITHOUT_FOO=yes and WITHOUT_FOO=no both make sense to enable it depending on your world view, which is likely informed by your native language is. In Spanish, double negatives are still negative, so that construct makes sense and =yes is weird. English speakers, on the other hand, would think WITHOUT_FOO=no is negating it so it should enable. WITH_FOO=no, though, never makes sense and is a common idiom for WITHOUT_FOO in other contexts... So I'm unsure what to do about the WITHOUT_FOO case.