Page MenuHomeFreeBSD
Differential D30037

bhyve: Set SO_REUSEADDR on the gdb stub socket
ClosedPublic
Actions

Authored by markj on Apr 29 2021, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 8:52 PM
Unknown Object (File)
Jan 16 2024, 7:37 AM
Unknown Object (File)
Dec 21 2023, 1:43 AM
Unknown Object (File)
Dec 20 2023, 5:28 AM
Unknown Object (File)
Dec 15 2023, 1:11 PM
Unknown Object (File)
Dec 8 2023, 4:54 PM
Unknown Object (File)
Dec 6 2023, 5:42 AM
Unknown Object (File)
Nov 22 2023, 9:22 AM
View All 33 Files
Subscribers
bcran
emaste
imp
jhb
rgrimes

Details

Reviewers
jhb
Group Reviewers
bhyve
Commits
rG9186e4eb65c0: bhyve: Set SO_REUSEADDR on the gdb stub socket
rGb2c871b1387e: bhyve: Set SO_REUSEADDR on the gdb stub socket
rG02e7a6514e63: bhyve: Set SO_REUSEADDR on the gdb stub socket
Summary

When using bhyve's gdb stub to debug some changes to the kernel's early
boot code, I frequently hit an error when reconnecting gdb. Set
SO_REUSEADDR to mitigate this, as we do for the VNC server.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Apr 29 2021, 3:52 PM
Herald added a reviewer: bhyve. · View Herald TranscriptApr 29 2021, 3:52 PM
Herald added subscribers: bcran, rgrimes, emaste, imp. · View Herald Transcript
markj requested review of this revision.Apr 29 2021, 3:52 PM
Harbormaster completed remote builds in B38924: Diff 88378.Apr 29 2021, 3:52 PM
rgrimes added inline comments.Apr 29 2021, 4:32 PM
usr.sbin/bhyve/gdb.c
1849

Why no check for errors from setsockopt call?

jhb accepted this revision.Apr 29 2021, 4:54 PM
jhb added a subscriber: jhb.
jhb added inline comments.
usr.sbin/bhyve/gdb.c
1849

Because failure isn't fatal probably? The VNC code in rfb.c doesn't check for errors either. In practice I don't think SO_REUSEADDR can fail for a TCP socket on FreeBSD.

This revision is now accepted and ready to land.Apr 29 2021, 4:54 PM
markj added inline comments.Apr 29 2021, 6:31 PM
usr.sbin/bhyve/gdb.c
1849

This was exactly my reasoning.

rgrimes added inline comments.Apr 29 2021, 7:48 PM
usr.sbin/bhyve/gdb.c
1849

The man page clearly indicates it can fail, and the one in dbgport.c does check status.

markj added inline comments.May 3 2021, 4:41 PM
usr.sbin/bhyve/gdb.c
1849

It will only fail for generic reasons, like if s is not a socket or a copyin of the optval fails.

Closed by commit rG02e7a6514e63: bhyve: Set SO_REUSEADDR on the gdb stub socket (authored by markj). · Explain WhyMay 3 2021, 5:56 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG02e7a6514e63: bhyve: Set SO_REUSEADDR on the gdb stub socket.
markj added a commit: rGb2c871b1387e: bhyve: Set SO_REUSEADDR on the gdb stub socket.May 10 2021, 1:50 PM
markj added a commit: rG9186e4eb65c0: bhyve: Set SO_REUSEADDR on the gdb stub socket.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
5 lines

Diff 88562

View Options

usr.sbin/bhyve/gdb.c

Loading...