Page MenuHomeFreeBSD

devel/sd-mux-ctrl: Rename to match upstream
ClosedPublic

Authored by sbz on Apr 12 2021, 5:30 PM.

Details

Reviewers
swills
Summary

Rename devel/sd-mux to devel/sd-mux-ctrl and remove dupplicate port
sysutils/sd-mux-ctrl added recently. As the port names were different
addport -y didn't catch the dupplicate when looking at the catalog tree
INDEX. Also add entries into MOVED.

Approved by: swills

Test Plan
  • Ok poudriere testport -o devel/sd-mux-ctrl
  • Ok port test

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 38538
Build 35427: arc lint + arc unit

Event Timeline

sbz requested review of this revision.Apr 12 2021, 5:30 PM
devel/sd-mux-ctrl/files/patch-src_CMakeLists.txt
12

Someone who knows CMake better should say if this patch or the other are better in some way or more upstream-able. I suspect the other one is. Have we tried to get either upstream? I don't think I bothered with mine, but we should. Upstream-ing shouldn't hold up this change, but we should decide which patch will work upstream and stick with that for this change.

devel/sd-mux-ctrl/pkg-descr
4

Might be nice to preserve the other link to the SDWire wiki page so folks can figure out what this is better. It's OK to have two links in pkg-descr, btw.

preserve the link to the wiki page in pkg-descr

sbz marked an inline comment as done.Apr 13 2021, 4:45 PM
devel/sd-mux-ctrl/files/patch-src_CMakeLists.txt
12

I just kept the patch as before and it works as expected, i.e. nothing was changed. For the upstream question of the patches, I'm agreed and I think it should be chased during the next release update.

I just kept the patch as before and it works as expected, i.e. nothing was changed. For the upstream question of the patches, I'm agreed and I think it should be chased during the next release update.

Ok, fine, I'll do it.

devel/sd-mux-ctrl/files/patch-src_CMakeLists.txt
12

I just kept the patch as before and it works as expected, i.e. nothing was changed. For the upstream question of the patches, I'm agreed and I think it should be chased during the next release update.

This revision is now accepted and ready to land.Apr 13 2021, 6:03 PM
emaste added inline comments.
devel/sd-mux-ctrl/files/patch-src_CMakeLists.txt
12

I think the other one is more upstreamable and we should use that one. That said, @gonzo tried and they were unresponsive. There's a link to the upstream submission somewhere in the thread at https://twitter.com/kernelnomicon/status/1284230380887789568 I think.