efivar: Add --quiet to not report errors
ClosedPublic
Actions

Authored by imp on Apr 7 2021, 5:41 AM.

Details

Reviewers

jhb
markj

Group Reviewers

manpages

Commits

rG36a9057e043b: efivar: Add --quiet to not report errors
rG3c0dcbfc8501: efivar: Add --quiet to not report errors

Summary

Add -q/--quiet flag to the command line. With it, errors are not reported at
all. Instead nothing is printed and the exit code is non-zero.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38439
Build 35328: arc lint + arc unit

Event Timeline

imp created this revision.Apr 7 2021, 5:41 AM

Herald added a reviewer: manpages. · View Herald TranscriptApr 7 2021, 5:41 AM

imp requested review of this revision.Apr 7 2021, 5:41 AM

Harbormaster completed remote builds in B38375: Diff 86940.Apr 7 2021, 5:41 AM

imp added reviewers: jhb, markj.Apr 7 2021, 5:42 AM

OK from manpages.

LGTM with the comments addressed.

usr.sbin/efivar/efivar.8
35	List -q here too?
usr.sbin/efivar/efivar.c
84	Presumably the short options should be updated as well?

This revision is now accepted and ready to land.Apr 7 2021, 1:23 PM

Address markj's issues.

This revision now requires review to proceed.Apr 8 2021, 10:17 PM

Harbormaster completed remote builds in B38439: Diff 87087.Apr 8 2021, 10:17 PM

markj accepted this revision.Apr 9 2021, 1:51 PM

This revision is now accepted and ready to land.Apr 9 2021, 1:51 PM

Closed by commit rG3c0dcbfc8501: efivar: Add --quiet to not report errors (authored by imp). · Explain WhyApr 9 2021, 10:39 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG3c0dcbfc8501: efivar: Add --quiet to not report errors.

vangyzen added a commit: rG36a9057e043b: efivar: Add --quiet to not report errors.Mar 2 2022, 10:01 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

efivar/

efivar.8

10 lines

efivar.c

62 lines

Diff 87087

View Options

usr.sbin/efivar/efivar.8