Page MenuHomeFreeBSD

Mention the committer group of the phabricator in committer's guide
Needs RevisionPublic

Authored by lwhsu on Mar 16 2021, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 5:20 AM
Unknown Object (File)
Nov 21 2023, 9:09 AM
Unknown Object (File)
Nov 8 2023, 1:17 AM
Unknown Object (File)
Oct 31 2023, 1:15 PM
Unknown Object (File)
Oct 7 2023, 12:11 AM
Unknown Object (File)
Sep 29 2023, 1:15 PM
Unknown Object (File)
Jun 13 2023, 5:29 PM
Unknown Object (File)
Jan 5 2023, 12:29 PM

Details

Reviewers
ygy
Group Reviewers
docs
phabric-admin
Summary

Mention the committer group of the phabricator in committer's guide

This is more like opening a discussion to collect the suggested wording and description.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 37875
Build 34764: arc lint + arc unit

Event Timeline

lwhsu requested review of this revision.Mar 16 2021, 9:39 PM
lwhsu created this revision.
ygy added inline comments.
documentation/content/en/articles/committers-guide/_index.adoc
1909

I think it can be rephrased as something like:

You can apply to join the [`committer`] project to be able to...

Also, "tocket" sounds like a typo ;)

ceri added inline comments.
documentation/content/en/articles/committers-guide/_index.adoc
1909

Are we really clear on what this allows one to do? I was able to join the docs project without joining committers first.

pauamma_gundo.com added inline comments.
documentation/content/en/articles/committers-guide/_index.adoc
1909

ISTR "you" is frowned upon. Or is that no longer the case?

1909
documentation/content/en/articles/committers-guide/_index.adoc
1909

I think @pauamma_gundo.com's suggestion is better :)

@ceri, at the time of review I need someone to add myself to "committer" and then I can do self-service... Not sure if it is still the case, maybe @lwhsu can confirm.

ygy requested changes to this revision.Jun 12 2021, 5:34 AM
This revision now requires changes to proceed.Jun 12 2021, 5:34 AM