Page MenuHomeFreeBSD

Fix usr.bin/procstat/tests to be executed in parallel mode
AbandonedPublic

Authored by olivier on Mar 16 2021, 5:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 1 2024, 2:52 AM
Unknown Object (File)
Oct 5 2023, 12:13 PM
Unknown Object (File)
Aug 15 2023, 1:54 AM
Unknown Object (File)
Mar 22 2023, 8:00 AM
Unknown Object (File)
Mar 4 2023, 9:30 PM
Unknown Object (File)
Jan 17 2023, 1:27 AM
Unknown Object (File)
Dec 24 2022, 11:55 PM

Details

Reviewers
asomers
Group Reviewers
tests
Summary

All usr.bin/procstat tests are using the same filename procstat.out, that could create conflict if executed with parallelism enabled: switching to a dedicated filename.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

olivier created this revision.
asomers requested changes to this revision.Mar 16 2021, 6:13 PM
asomers added a subscriber: asomers.

It doesn't matter, because Kyua executes the tests in separate temporary directories.

This revision now requires changes to proceed.Mar 16 2021, 6:13 PM

You've right, those are not the source of the problem.
For history, here is the problem sometimes happen in parallel mode:

usr.bin.procstat.procstat_test.kernel_stacks (from (test-report.xml))

Failing for the past 1 build (Since Unstable#3422 )
Took 0.35 sec.
add description
Error Message
atf-check failed; see the output of the test for details
Standard Output
Executing command [ procstat -a kstack ]
Standard Error
Test case metadata
------------------

allowed_architectures is empty
allowed_platforms is empty
description = Captures kernel stacks for all visible threads
has_cleanup = false
is_exclusive = false
required_configs is empty
required_disk_space = 0
required_files is empty
required_memory = 0
required_programs is empty
required_user is empty
timeout = 300

Timing information
------------------

Start time: 2021-03-16T21:20:31.257142Z
End time:   2021-03-16T21:20:31.608909Z
Duration:   0.352s

Original stderr
---------------

Fail: stderr not empty
--- /dev/null	2021-03-16 21:20:31.519139000 +0000
+++ /tmp/kyua.T7vVVo/3134/work/check.tL25KQ/stderr	2021-03-16 21:20:31.516474000 +0000
@@ -0,0 +1 @@
+procstat: sysctl: kern.proc.pid: 19263: No such process

You've right, those are not the source of the problem.
For history, here is the problem sometimes happen in parallel mode:

usr.bin.procstat.procstat_test.kernel_stacks (from (test-report.xml))

Failing for the past 1 build (Since Unstable#3422 )
Took 0.35 sec.
add description
Error Message
atf-check failed; see the output of the test for details
Standard Output
Executing command [ procstat -a kstack ]
Standard Error
Test case metadata
------------------

allowed_architectures is empty
allowed_platforms is empty
description = Captures kernel stacks for all visible threads
has_cleanup = false
is_exclusive = false
required_configs is empty
required_disk_space = 0
required_files is empty
required_memory = 0
required_programs is empty
required_user is empty
timeout = 300

Timing information
------------------

Start time: 2021-03-16T21:20:31.257142Z
End time:   2021-03-16T21:20:31.608909Z
Duration:   0.352s

Original stderr
---------------

Fail: stderr not empty
--- /dev/null	2021-03-16 21:20:31.519139000 +0000
+++ /tmp/kyua.T7vVVo/3134/work/check.tL25KQ/stderr	2021-03-16 21:20:31.516474000 +0000
@@ -0,0 +1 @@
+procstat: sysctl: kern.proc.pid: 19263: No such process

That sounds like procstat -a should handle processes dying better.