Page MenuHomeFreeBSD

Relnotes/13.0: Add routing work description
ClosedPublic

Authored by melifaro on Mar 15 2021, 8:39 PM.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 38481
Build 35370: arc lint + arc unit

Event Timeline

melifaro created this revision.
melifaro retitled this revision from Add routing work description to Relnotes/13.0: Add routing work description.Mar 15 2021, 8:41 PM
melifaro added reviewers: gjb, debdrup.
website/content/en/releases/13.0R/relnotes.adoc
460

Q: what is the proper way to reference the person who contributed this change?

I'm unsure about inlining commit hashes or revisions, so I think @gjb will have to weigh in on whether commit hashes should be referenced at the end like it's done with other things mentioned in the release notes.
I'm more partial to this, as this is how release notes have always looked, but I'm not against the change, as long as it's uniform across the whole document.

website/content/en/releases/13.0R/relnotes.adoc
425
427
428
430
446
447
448
450

Is there a line too many here?

452
453
454
455
457
460

The authorship is noted in that commit, so unless they explicitly asked to be mentioned in the release notes, I'm not sure.

460
melifaro marked 13 inline comments as done.

Address comments.

Looks good to me now, go ahead and commit with Approved by: debdrup

This revision is now accepted and ready to land.Apr 10 2021, 12:06 PM

Remove rev-named in favor of currently existing macro, as it's too late to change the rest of the release notes.

This revision now requires review to proceed.Apr 10 2021, 12:38 PM

Only one tiny nit left, then you can go ahead and commit it with Approved by: debdrup

website/content/en/releases/13.0R/relnotes.adoc
460

The colon should be a period.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2021, 12:50 PM
This revision was automatically updated to reflect the committed changes.