Differential D2893

graphics/opencv: fix configure when EIGEN is off
ClosedPublic
Actions

Authored by avilla on Jun 23 2015, 8:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 4, 11:53 AM

	Unknown Object (File)
	Nov 9 2024, 1:06 AM

	Unknown Object (File)
	Oct 24 2024, 4:25 AM

	Unknown Object (File)
	Oct 23 2024, 2:23 AM

	Unknown Object (File)
	Oct 21 2024, 2:32 AM

	Unknown Object (File)
	Oct 5 2024, 8:46 PM

	Unknown Object (File)
	Oct 5 2024, 8:46 PM

	Unknown Object (File)
	Oct 5 2024, 6:13 PM

View All 90 Files

Subscribers

None

Details

Reviewers

Commits

rP390659: MFH: r390539
rP390539: graphics/opencv: fix configure when EIGEN is off

Summary

When EIGEN option is off, CMAKE_ARGS is reset, thus enabling build of tests and docs (causing some leftovers), and, should it be installed, linking against libdc1394 even when option DC1394 is off. PORTREVISION bump is needed to address the latter case.

Meanwhile, re-enable make jobs.

Test Plan

Install libdc1394, then build with EIGEN and DC1394 off, and check CMake log: it will show support for DC1394. Also, it will fail at check-plist due to docs being built.

Make jobs were tested several times on ref* machine with 24 concurrent jobs and many combinations of options.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avilla updated this revision to Diff 6409.Jun 23 2015, 8:27 PM

avilla retitled this revision from to graphics/opencv: fix configure when EIGEN is off.

avilla updated this object.

avilla edited the test plan for this revision. (Show Details)

avilla added a reviewer: jhale.

avilla set the repository for this revision to rP FreeBSD ports repository.

jhale accepted this revision.Jun 24 2015, 12:09 AM

jhale edited edge metadata.

This revision is now accepted and ready to land.Jun 24 2015, 12:09 AM

Closed by commit rP390539: graphics/opencv: fix configure when EIGEN is off (authored by avilla). · Explain WhyJun 25 2015, 8:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

graphics/

opencv/

5 lines

Diff 6455

head/graphics/opencv/Makefile

Loading...