Those two appear unused; gc them.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 37383 Build 34272: arc lint + arc unit
Event Timeline
sys/cam/cam_ccb.h | ||
---|---|---|
920 | I am curios why you've removed resetbus, but left resetdev. Obviously the last one is used in virtio_scsi, but if we assume that every opcode should have its structure, then both should stay, even if they are identical. | |
1212 | Same as above -- if you want to delete structure, you should also delete the opcode, if we consider it obsolete. |
Comment Actions
Thanks; I've completely missed the structure<->opcode relationship. I think I'll start again, this time with just ccb_eng_inq and ccb_eng_exec, removing both the struct and the opcodes.
Comment Actions
In the end I didn't need to change CCB layout, so let's keep this as it is. You're right that it might be used by SpectraLogic's internal stuff, removing it could generate unneeded diff for them.