Page MenuHomeFreeBSD

cam: drop 'struct ccb_eng_exec' and 'struct ccb_eng_inq'.
AbandonedPublic

Authored by trasz on Feb 14 2021, 11:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 3, 11:49 PM
Unknown Object (File)
Jan 1 2024, 7:38 AM
Unknown Object (File)
Nov 18 2023, 1:16 AM
Unknown Object (File)
Nov 18 2023, 12:41 AM
Unknown Object (File)
Nov 17 2023, 9:51 PM
Unknown Object (File)
Nov 17 2023, 9:43 PM
Unknown Object (File)
Nov 13 2023, 7:23 AM
Unknown Object (File)
Aug 2 2023, 6:28 PM
Subscribers

Details

Reviewers
imp
scottl
ken
mav
Group Reviewers
cam
manpages
Summary

Those two appear unused; gc them.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37383
Build 34272: arc lint + arc unit

Event Timeline

looks good to me, but scott or ken would know why they are here.

This revision is now accepted and ready to land.Feb 15 2021, 1:07 AM
This revision now requires review to proceed.Feb 15 2021, 12:31 PM
sys/cam/cam_ccb.h
920

I am curios why you've removed resetbus, but left resetdev. Obviously the last one is used in virtio_scsi, but if we assume that every opcode should have its structure, then both should stay, even if they are identical.

1212

Same as above -- if you want to delete structure, you should also delete the opcode, if we consider it obsolete.

Thanks; I've completely missed the structure<->opcode relationship. I think I'll start again, this time with just ccb_eng_inq and ccb_eng_exec, removing both the struct and the opcodes.

Don't touch bus resets nor ack for now.

I have no specific objections, but I suppose those were added for something.

This revision is now accepted and ready to land.Mar 3 2021, 9:55 PM

In the end I didn't need to change CCB layout, so let's keep this as it is. You're right that it might be used by SpectraLogic's internal stuff, removing it could generate unneeded diff for them.