Fix building ports that use libx264 with -Werror
ClosedPublic
Actions

Authored by kwm on Jun 19 2015, 6:13 AM.

Details

Reviewers

Commits

rP390114: Our stdint.h is a symlink to sys/stdint.h so we need to teach x264 the

Summary

CC       libgstx264_la-gstx264enc.lo

In file included from gstx264enc.c:101:
In file included from ./gstx264enc.h:28:
/usr/local/include/x264.h:36:4: error: You must include stdint.h or inttypes.h before x264.h [-Werror,-W#warnings]

warning You must include stdint.h or inttypes.h before x264.h

1 error generated.

ll /usr/include/stdint.h
lrwxr-xr-x 1 root wheel 12 Jun 13 19:33 /usr/include/stdint.h@ -> sys/stdint.h

This error is caused by our /usr/include/stdint.h header being a symlink
to /usr/include/sys/stdint.h. And x264.h explicitly checking for the
header guards. Add our's to the list so it will compile again.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kwm updated this revision to Diff 6317.Jun 19 2015, 6:13 AM

kwm retitled this revision from to Fix building ports that use libx264 with -Werror.

kwm updated this object.

kwm added a reviewer: koobs.

Actualy put the patch file in the right dir.

Upstream (#x264dev @ freenode) says:

MasterNobody   │ looks ok if there header have such guard and no another stdint.h
BugMaster|work │ ^
BugMaster|work │ which OS is this?
BugMaster|work │ or which of BSD
         koobs │ FreeBSD
BugMaster|work │ and how they compiled it before? or they changed headers not so long ago?
...
Daemon404      │ projects that use -Werror should be burned at the stake
    koobs      │ I agree, but that is beside the point of the fix :)

         koobs │ BugMaster|work: can you usher the change in at your end?
         koobs │ or where can i report the issue and attach the patch? 
BugMaster|work │ can add myself or if you send patch will add with you as author (iirc you already signed CLA?).
         koobs │ BugMaster|work: dont need to sign CLA, im happy for you to usher it in. Patch written by Koop Mast <kwm@FreeBSD.org>
         koobs │ You can just reference our review URL if you like
         koobs │ BugMaster|work: i appreciate the help

This revision is now accepted and ready to land.Jun 19 2015, 12:57 PM

Closed by commit rP390114: Our stdint.h is a symlink to sys/stdint.h so we need to teach x264 the (authored by kwm). · Explain WhyJun 19 2015, 1:12 PM

This revision was automatically updated to reflect the committed changes.