Page MenuHomeFreeBSD
Differential D28535

Increase SMMU timeout
AcceptedPublic
Actions

Authored by br on Feb 8 2021, 12:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 22 2023, 12:22 PM
Unknown Object (File)
Oct 8 2023, 12:50 PM
Unknown Object (File)
Jun 22 2023, 12:54 AM
Unknown Object (File)
Apr 8 2023, 10:34 AM
Unknown Object (File)
Mar 22 2023, 7:55 AM
Unknown Object (File)
Jan 16 2023, 1:18 PM
Unknown Object (File)
Dec 28 2022, 6:18 AM
Subscribers
dsl
emaste

Details

Reviewers
andrew
manu
Summary

I noticed a single occurance of "smmu0: Failed to sync" during "make -j4 buildworld". So:

o Increase wait timeout
o DELAY(1) between attempts
o add macro SMMU_POLL_TIMEOUT_US

This is similar to what linux is doing.

Test Plan

Will be tested with
-j4 buildworld on N1SDP

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br created this revision.Feb 8 2021, 12:27 PM
Herald added a reviewer: manu. · View Herald TranscriptFeb 8 2021, 12:27 PM
Herald added a subscriber: emaste. · View Herald Transcript
br requested review of this revision.Feb 8 2021, 12:27 PM
br edited the summary of this revision. (Show Details)Feb 8 2021, 12:29 PM
br edited the summary of this revision. (Show Details)
andrew accepted this revision.Feb 9 2021, 1:59 PM
This revision is now accepted and ready to land.Feb 9 2021, 1:59 PM
br added a comment.Feb 23 2021, 7:47 PM

Sadly but this failed testing even if I put DELAY(100).
I'll need to find out which request failed exactly.

dsl added a subscriber: dsl.Jun 17 2021, 1:55 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
iommu/
5 lines

Diff 83535

View Options

sys/arm64/iommu/smmu.c

Loading...